Repository navigation
Fix SimpleNonlinearSolve keyword override flags and parameterless GPU solves - #1240
Conversation
Honor simultaneous u0/p overrides and avoid remaking unchanged immutable problems inside GPU kernels. Cover keyword combinations and parameterless CUDA kernel solves. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Codex <noreply@openai.com> Agent-Harness: Codex (version unknown) Agent-Model: unknown Agent-Session: local session ID 01a07fcc-1c4f-7ee3-9a1e-51eaab7df293
|
Additional Julia 1.13 validation while investigating the OpenCL CI failure in SciML/DiffEqGPU.jl#532: I reran the owner-level parameterless OpenCL kernel reproducer already included in this PR body. It imports SimpleNonlinearSolve, SciMLBase, StaticArrays, KernelAbstractions, OpenCL, pocl_jll, and Test; it does not import DiffEqGPU or Enzyme. With registered SimpleNonlinearSolve 2.14.3, the process exits 1: The stack traces go through Both runs use SciMLBase 3.53.3, OpenCL 0.10.11, GPUCompiler 2.6.0, KernelAbstractions 0.9.42, and pocl_jll 7.1.3+9. The developed checkout declares SimpleNonlinearSolve 2.14.2. Commands from the workspace root: julia +1.13.0 --project=scratch/ci-investigation/master-check-env scratch/ci-investigation/owner-init-minimal.jl
julia +1.13.0 --project=scratch/ci-investigation/owner-init-fix-env scratch/ci-investigation/owner-init-minimal.jl
This independently reproduces the dependency failure on the official Julia 1.13 release. The existing Julia 1.12 reproduction in the PR body shows it is not exclusive to Julia 1.13. Source-history tracing still points to cc61d5a for introduction of the inverted predicates; no historical dependency-environment runtime bisect is claimed. 🤖 Written with Codex CLI 0.153.4 (model: gpt-6-astra). Local session ID: |
- Fix SimpleNonlinearSolve keyword override flags and parameterless GPU solves (#1240) Agent-Harness: Claude Code Agent-Model: claude-opus-5[1m] Claude-Session: https://claude.ai/code/session_014FEzNTLFutCmTEAZ3zBg5R Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Supplying both
u0andpto a SimpleNonlinearSolve solve currently ignores both overrides because theu0_changed/p_changedflags are inverted. Correct the two predicates so supplied overrides triggerremake, while calls without overrides avoid it. The latter also restores parameterless immutable nonlinear solves inside OpenCL kernels, which previously compiled through an unnecessaryremakeand failed with invalid GPU IR.Added all four keyword combinations for mutable and immutable problems to the existing Core kwargs tests, plus a parameterless kernel regression to the existing CUDA group. No dependencies or public signatures change.
Ignore this PR until reviewed by @ChrisRackauckas.
Failing before / passing after
On unmodified owner master
0dccd34d125638394c2f3e5e53be3b5e272896a0, running the exact new Core testset with Julia 1.12.7 produced:Both failures are simultaneous keyword overrides. The identical testset after the fix:
Command:
julia +1.12 --project=scratch/nonlinear-owner-fix-env scratch/nonlinear_override_regression.jl(the script imports SimpleNonlinearSolve/SciMLBase/Test and contains the new testset verbatim).An independent owner-level reproduction uses OpenCL 0.10.11 / GPUCompiler 2.5.4 / POCL and imports no DiffEqGPU:
Before:
InvalidIRError, including unsupportedjulia.new_gc_frameandtypejoincalls throughremake. After: exit 0 with the output assertion passing. The same environment with clean DiffEqGPU master and its initialization-preprocessing test changes from InvalidIR to:Source-history tracing finds the inverted predicates introduced in cc61d5a . This is source provenance; no historical 2024 dependency-environment runtime bisect is claimed.
Validation
Commands:
Core completed with 35,620 passing assertions and four pre-existing broken assertions; no tests were skipped, disabled, or altered to suppress failure. Tail:
QA:
Runic, typos over the changed files, and
git diff --checkpass. No docs/public API additions; docs build not run. CUDA hardware tests, adjoint tests, and the full monorepo suite were not run. The new CUDA regression uses the same problem/solve/output operation exercised locally through OpenCL/POCL, but CUDA compilation itself remains unverified.🤖 Generated with Codex (harness version: unknown; exact model ID: unknown). Local session ID:
01a07fcc-1c4f-7ee3-9a1e-51eaab7df293; no shareable conversation URL exposed.