chore: enforce awaiting promises by lint

eslint.config.mjs

@@ -55,6 +55,8 @@ export default [
 
       "@typescript-eslint/no-explicit-any": "error",
       "@typescript-eslint/no-inferrable-types": "error",
+      "@typescript-eslint/no-floating-promises": "error",
+      "@typescript-eslint/no-misused-promises": "error",
 
       quotes: [
         "error",

src/auth/access-group-provider/access-group-service-factory.ts

@@ -13,7 +13,7 @@ import { Logger } from "@nestjs/common";
  */
 export const accessGroupServiceFactory = {
   provide: AccessGroupService,
-  useFactory: (configService: ConfigService) => {
+  useFactory: async (configService: ConfigService) => {
     Logger.debug("Service factory starting", "accessGroupServiceFactory");
     const accessGroupsStaticConfig = configService.get(
       "accessGroupsStaticConfig",
@@ -68,26 +68,32 @@ export const accessGroupServiceFactory = {
         "loading graphql processor",
       );
 
-      import(accessGroupsGraphQlConfig.responseProcessorSrc).then(
-        (rpModule) => {
-          const gh = rpModule.graphHandler;
-          const responseProcessor: (
-            response: Record<string, unknown>,
-          ) => string[] = gh.responseProcessor;
-          const graphqlTemplateQuery: string = gh.graphqlTemplateQuery;
-          accessGroupServices.push(
-            new AccessGroupFromGraphQLApiService(
-              graphqlTemplateQuery,
-              accessGroupsGraphQlConfig.apiUrl,
-              {
-                Authorization: `Bearer ${accessGroupsGraphQlConfig.token}`,
-              },
-              responseProcessor,
-              new HttpService(),
-            ),
-          );
-        },
-      );
+      try {
+        const rpModule = await import(
+          accessGroupsGraphQlConfig.responseProcessorSrc
+        );
+        const gh = rpModule.graphHandler;
+        const responseProcessor: (
+          response: Record<string, unknown>,
+        ) => string[] = gh.responseProcessor;
+        const graphqlTemplateQuery: string = gh.graphqlTemplateQuery;
+        accessGroupServices.push(
+          new AccessGroupFromGraphQLApiService(
+            graphqlTemplateQuery,
+            accessGroupsGraphQlConfig.apiUrl,
+            {
+              Authorization: `Bearer ${accessGroupsGraphQlConfig.token}`,
+            },
+            responseProcessor,
+            new HttpService(),
+          ),
+        );
+      } catch (error) {
+        Logger.error(
+          `Failed to load graphql response processor from "${accessGroupsGraphQlConfig.responseProcessorSrc}", skipping this access group provider: ${error}`,
+          "accessGroupServiceFactory",
+        );
+      }
     }
     if (accessGroupsRestConfig?.enabled == true) {
       Logger.log(

src/auth/auth.service.ts

@@ -103,7 +103,7 @@ export class AuthService {
     const logoutResult = await this.additionalLogoutTasks(req, logoutURL);
 
     if (expressSessionSecret) {
-      req.logout(async (err) => {
+      req.logout((err) => {
         if (err) {
           // we should provide a message
           Logger.error("Logout error: ", err);

src/datasets/datasets.module.ts

@@ -76,7 +76,7 @@ import { OpensearchModule } from "src/opensearch/opensearch.module";
             } else {
               const regexLiteral = /(?<=AV\=)(.*?)(?=\,)/g;
               av = (regexLiteral.exec(this.classification ?? "") || ["low"])[0];
-              policyService.addDefaultPolicy(
+              await policyService.addDefaultPolicy(
                 this.ownerGroup,
                 this.accessGroups,
                 this.ownerEmail ?? "",

src/main.ts

@@ -103,4 +103,7 @@ async function bootstrap() {
 
   await app.listen(port);
 }
-bootstrap();
+bootstrap().catch((error) => {
+  Logger.error("Failed to bootstrap the application", error, "Main");
+  process.exit(1);
+});

src/opensearch/opensearch.service.ts

@@ -73,7 +73,13 @@ export class OpensearchService implements OnModuleInit {
   }
 
   onModuleInit() {
-    this.initWithRetry();
+    this.initWithRetry().catch((error) => {
+      Logger.error(
+        "Opensearch initialization failed unexpectedly",
+        error,
+        "Opensearch",
+      );
+    });
   }
 
   private async connect() {

src/users/users.service.ts

@@ -142,13 +142,15 @@ export class UsersService implements OnModuleInit {
           };
           const createdRole = await this.rolesService.findOrCreate(createRole);
           if (createdRole && userIds) {
-            userIds.forEach(async (userId) => {
-              const createUserRole: CreateUserRoleDto = {
-                userId: userId,
-                roleId: createdRole._id,
-              };
-              await this.rolesService.findOrCreateUserRole(createUserRole);
-            });
+            await Promise.all(
+              userIds.map(async (userId) => {
+                const createUserRole: CreateUserRoleDto = {
+                  userId: userId,
+                  roleId: createdRole._id,
+                };
+                await this.rolesService.findOrCreateUserRole(createUserRole);
+              }),
+            );
           }
         }
       }