Repository navigation
Replace yanked secp256k1 beta - #167
Open
ethicnology-agent wants to merge 1 commit into
Open
ethicnology-agent wants to merge 1 commit into
ethicnology-agent wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secp256k10.32 beta dependency with 0.33.1Cargo.locktosecp256k1-sys0.14.1This is the follow-up dependency migration described in #165.
Testing
make cargo-buildmake cargo-clippymake wasm-buildmake wasm-clippymake wasm-test --headless --firefox(34 passed, 13 ignored)make wasm-regtest-test(7 passed)bindings:make check-pythonandmake build-debugThe complete native test commands also reach two Liquid node tests that cannot start on Linux aarch64 because the
elementsddownload feature is enabled only on x86_64; the same failures reproduce onorigin/trunk. The generated WASM consumer compiles on both the base and this branch, then both hit the same local arm64wasm-optbulk-memory validation failure.