Repository navigation
fix: harden swap validation - #163
Merged
Merged
Conversation
This was referenced Aug 12, 2026
i5hi
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harden Bitcoin and Liquid swap handling against malformed or inconsistent server responses.
This PR:
DebugoutputSecurity impact
Previously, some server-provided values were trusted independently even when they described the same swap. A compromised or faulty server could therefore return inconsistent scripts, keys, transactions, amounts, or network data and defer failure until a later signing or broadcasting step.
The new checks bind these values together and reject inconsistencies before funds are claimed, refunded, or cooperatively signed.
Compatibility
Valid swaps keep the same behavior.
The changes intentionally reject malformed or internally inconsistent API responses that may previously have progressed further through the swap flow.