Audeze Maxwell Noise Filter Capability and Audeze Maxwell 2 Protocol#517
Audeze Maxwell Noise Filter Capability and Audeze Maxwell 2 Protocol#517ModoloDev wants to merge 1 commit into
Conversation
…e maxwell 2 protocol
|
I'm running a build of this branch (on Fedora 44 KDE) and it's working well for me so far. Compared to master it seems to be much more reliable about successfully reporting battery status immediately after connecting. I have the PlayStation edition of the original Maxwell (not 2). It can still be a bit wonky and imprecise, with the battery level going up and down by a few points randomly. One time it reported 0% on the first run after connecting. But like I said in #460 it's not obviously any worse than the official app, and could just be down to how the battery level is measured in the first place like Sapd said (this isn't a topic I really know anything about). |
| */ | ||
| class AudezeMaxwell : public HIDDevice { | ||
| public: | ||
| static constexpr std::array<uint16_t, 3> SUPPORTED_PRODUCT_IDS { |
There was a problem hiding this comment.
Just noticed for some reason the array size is wrong, we could directly fix it here
| final_minutes = 120; | ||
| else if (minutes <= 240) | ||
| final_minutes = 240; | ||
| uint16_t final_minutes = map(minutes, 0, 90, 0, 360); |
There was a problem hiding this comment.
Seems to be semantically incorrect.
Passing in 5 minutes, the user would get 20
| } | ||
|
|
||
| // Parse microphone mute status (FF = unmuted) | ||
| status.mic_muted = status_buffs[1][12] != 0xFF; |
There was a problem hiding this comment.
We could in pass that information btw in BatteryResult back
| if (mapped == 0) { | ||
| // Toggle sidetone off | ||
| std::array<uint8_t, MSG_SIZE> toggle_cmd { 0x6, 0x9, 0x80, 0x5, 0x5a, 0x5, 0x0, 0x82, 0x2c, 0x7, 0x0, 0x1 }; | ||
| std::array<uint8_t, MSG_SIZE> toggle_cmd { 0x06, 0x09, 0x80, 0x05, 0x5A, 0x05, 0x00, 0x82, 0x2C, 0x07, 0x00, 0x00 }; |
There was a problem hiding this comment.
Was it before the other way around? As its now 0x00 as last byte
3 participants
Changes made
Related to #460, it might fix some of the problems with battery status
Checklist