You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why "Movement.ManeuverColor.Red" is checked? Can this check be removed?
Please, check situation where ship has 3 stress tokens and them performs green maneuver.
(You can use console command "tokens assign" for testing)
I don't like that you unsibscribe from Rules.StressRule. You can cause bug in another upgrades like Chopper crew. (I don't remember any rebel ship with tech and crew, but it can be added in future.)
Maybe it is better to use "action.CanBePerformedWhileStressed" for BR/Boost?
You call "Ship can perform free Boost or Barrel Roll". This is different from card's text and maybe can cause unknown problems.
Overall, I like quality of code, but I think that we can use more elegant solution.
So, I propose to use event "Phases.BeforeActionSubPhaseStart" to check number of stress tokens and set "action.CanBePerformedWhileStressed" to "true". In this case they will be shown in usual "Choose action to perform" window, and you don't need to unsubscribe from rules / call "perfrom free action" method.
If you have questions - contact me on Slack or here.
Sounds good. I'll take a look at your suggestions and send an update in the next few days.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.