Implement Tail Call Optimize into ReturnCall Instruction

[makachanm]

I implemented a tail call optimize into WebAssembly 3's ReturnCall recursive instruction.
It currently unfinished, (the issue with type checking in the standard's spec, indirect call is not completed..) but it passes Return Call Test code.

[clover2123]

Please run tools/check_tidy.py --update to format the code according to the style guidelines.

[makachanm]

I applied. thanks.

[zherczeg]

This sounds like a good idea. I would simplify the parameter storing: the parameters are simply stored in a linear buffer, and copied by a memcpy.

[zherczeg]

Parameters are stored in a linear area:
https://github.com/Samsung/walrus/blob/main/src/interpreter/Interpreter.h#L57

Then the tco buffer could be copied here without changes.

[makachanm]

I'll rework parameter recover code with memcpy and Walrus's own vector implementation. Thanks for the feedback.

[makachanm]

I think lack of JIT version of TCO implement causes CI failure. I'll seperate it for future works.

[makachanm]

I've verified that all tests in the walrus suite are passing in the x64 local machine at interpret mode.

[clover2123]

There is a conflict in ByteCode.h file.
Please rebase it and push this pr again

[makachanm]

CI is failing when Clang compiler is used. I had no problem with GCC.
I'll fix it with reordering some parameter initialize order.

[clover2123]

Lastly, have you been able to test this patch for recursive tail calls?

[makachanm]

Lastly, have you been able to test this patch for recursive tail calls?

I'll do it through recursive fibonacci test. Thanks for the mention.

[makachanm]

I found fibonacci test makes call stack exhaustion. I'm analyzing what's problem with.

[makachanm]

Yup it passes 10000-depth fibonacci test without problems.
I removed some edge-case code so it may cause problem in JIT, but it's seems not a huge problem.

I'll add new edge-case logic into it.

[clover2123]

One more, this patch doesn't consider exceptions.
What if exception occurs during the execution of tail call?

[makachanm]

I found some inconsistency in parameter space. Copy to callee can be not a problem, but Copy from caller is making some corruption into buffer value.

I changed it does manually copy data one by one.