[NUI] Deprecate NUI.TTSPlayer by TCSACR-649#7582
Open
dongsug-song wants to merge 1 commit intoSamsung:DevelNUIfrom
Open
[NUI] Deprecate NUI.TTSPlayer by TCSACR-649#7582dongsug-song wants to merge 1 commit intoSamsung:DevelNUIfrom
dongsug-song wants to merge 1 commit intoSamsung:DevelNUIfrom
Conversation
Collaborator
Public API ChangedPlease follow the ACR process for the changed API below. Added: 0, Removed: 24, Changed: 0Removed- /// <since_tizen>3</since_tizen
- Tizen.NUI.TTSPlayer
- /// <since_tizen>5</since_tizen
- Tizen.NUI.TTSPlayer Tizen.NUI.TTSPlayer::Instance()
- /// <since_tizen>3</since_tizen
- System.Void Tizen.NUI.TTSPlayer::Pause()
- /// <since_tizen>3</since_tizen
- System.Void Tizen.NUI.TTSPlayer::Play(System.String)
- /// <since_tizen>3</since_tizen
- System.Void Tizen.NUI.TTSPlayer::Resume()
- /// <since_tizen>3</since_tizen
- System.Void Tizen.NUI.TTSPlayer::Stop()
- /// <since_tizen>3</since_tizen
- static Tizen.NUI.TTSPlayer Tizen.NUI.TTSPlayer::Get()
- /// <since_tizen>3</since_tizen
- static Tizen.NUI.TTSPlayer Tizen.NUI.TTSPlayer::Get(Tizen.NUI.TTSPlayer/TTSMode)
- /// <since_tizen>3</since_tizen
- Tizen.NUI.TTSPlayer/TTSState Tizen.NUI.TTSPlayer::GetState()
- /// <since_tizen>3</since_tizen
- System.EventHandler`1<Tizen.NUI.TTSPlayer/StateChangedEventArgs> Tizen.NUI.TTSPlayer::StateChanged
- /// <since_tizen>3</since_tizen
- Tizen.NUI.TTSPlayer/StateChangedEventArgs
- /// <since_tizen>3</since_tizen
- Tizen.NUI.TTSPlayer/TTSState Tizen.NUI.TTSPlayer/StateChangedEventArgs::NextState()
- /// <since_tizen>3</since_tizen
- Tizen.NUI.TTSPlayer/TTSState Tizen.NUI.TTSPlayer/StateChangedEventArgs::PrevState()
- /// <since_tizen>none</since_tizen
- System.Void Tizen.NUI.TTSPlayer/StateChangedEventArgs::.ctor()
- /// <since_tizen>3</since_tizen
- Tizen.NUI.TTSPlayer/TTSMode
- /// <since_tizen>none</since_tizen
- static Tizen.NUI.TTSPlayer/TTSMode Tizen.NUI.TTSPlayer/TTSMode::Default
- /// <since_tizen>none</since_tizen
- static Tizen.NUI.TTSPlayer/TTSMode Tizen.NUI.TTSPlayer/TTSMode::ModeNum
- /// <since_tizen>none</since_tizen
- static Tizen.NUI.TTSPlayer/TTSMode Tizen.NUI.TTSPlayer/TTSMode::Notification
- /// <since_tizen>none</since_tizen
- static Tizen.NUI.TTSPlayer/TTSMode Tizen.NUI.TTSPlayer/TTSMode::ScreenReader
- /// <since_tizen>3</since_tizen
- Tizen.NUI.TTSPlayer/TTSState
- /// <since_tizen>none</since_tizen
- static Tizen.NUI.TTSPlayer/TTSState Tizen.NUI.TTSPlayer/TTSState::Paused
- /// <since_tizen>none</since_tizen
- static Tizen.NUI.TTSPlayer/TTSState Tizen.NUI.TTSPlayer/TTSState::Playing
- /// <since_tizen>none</since_tizen
- static Tizen.NUI.TTSPlayer/TTSState Tizen.NUI.TTSPlayer/TTSState::Ready
- /// <since_tizen>none</since_tizen
- static Tizen.NUI.TTSPlayer/TTSState Tizen.NUI.TTSPlayer/TTSState::Unavailable
Internal API ChangedAdded: 24, Removed: 0, Changed: 0Added+ /// <since_tizen>3</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.TTSPlayer
+ /// <since_tizen>5</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.TTSPlayer Tizen.NUI.TTSPlayer::Instance()
+ /// <since_tizen>3</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.TTSPlayer::Pause()
+ /// <since_tizen>3</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.TTSPlayer::Play(System.String)
+ /// <since_tizen>3</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.TTSPlayer::Resume()
+ /// <since_tizen>3</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.TTSPlayer::Stop()
+ /// <since_tizen>3</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.TTSPlayer Tizen.NUI.TTSPlayer::Get()
+ /// <since_tizen>3</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.TTSPlayer Tizen.NUI.TTSPlayer::Get(Tizen.NUI.TTSPlayer/TTSMode)
+ /// <since_tizen>3</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.TTSPlayer/TTSState Tizen.NUI.TTSPlayer::GetState()
+ /// <since_tizen>3</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.EventHandler`1<Tizen.NUI.TTSPlayer/StateChangedEventArgs> Tizen.NUI.TTSPlayer::StateChanged
+ /// <since_tizen>3</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.TTSPlayer/StateChangedEventArgs
+ /// <since_tizen>3</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.TTSPlayer/TTSState Tizen.NUI.TTSPlayer/StateChangedEventArgs::NextState()
+ /// <since_tizen>3</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.TTSPlayer/TTSState Tizen.NUI.TTSPlayer/StateChangedEventArgs::PrevState()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.TTSPlayer/StateChangedEventArgs::.ctor()
+ /// <since_tizen>3</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.TTSPlayer/TTSMode
+ /// <since_tizen>none</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.TTSPlayer/TTSMode Tizen.NUI.TTSPlayer/TTSMode::Default
+ /// <since_tizen>none</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.TTSPlayer/TTSMode Tizen.NUI.TTSPlayer/TTSMode::ModeNum
+ /// <since_tizen>none</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.TTSPlayer/TTSMode Tizen.NUI.TTSPlayer/TTSMode::Notification
+ /// <since_tizen>none</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.TTSPlayer/TTSMode Tizen.NUI.TTSPlayer/TTSMode::ScreenReader
+ /// <since_tizen>3</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.TTSPlayer/TTSState
+ /// <since_tizen>none</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.TTSPlayer/TTSState Tizen.NUI.TTSPlayer/TTSState::Paused
+ /// <since_tizen>none</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.TTSPlayer/TTSState Tizen.NUI.TTSPlayer/TTSState::Playing
+ /// <since_tizen>none</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.TTSPlayer/TTSState Tizen.NUI.TTSPlayer/TTSState::Ready
+ /// <since_tizen>none</since_tizen
+ [Obsolete]
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.TTSPlayer/TTSState Tizen.NUI.TTSPlayer/TTSState::Unavailable
|
wiertel
reviewed
Apr 22, 2026
| /// </summary> | ||
| /// <since_tizen> 3 </since_tizen> | ||
| [Obsolete("This has been deprecated in API14. Please use Tizen.Uix.Tts instead.")] | ||
| [EditorBrowsable(EditorBrowsableState.Never)] |
Member
There was a problem hiding this comment.
Obsolete is good, but why hiding the API with EditorBrowsable too? To me it's an overkill. Please consider removing all the added EditorBrowsable.
Comment on lines
97
to
+99
| /// </summary> | ||
| [Obsolete("This has been deprecated in API14. Please use Tizen.Uix.Tts instead.")] | ||
| [EditorBrowsable(EditorBrowsableState.Never)] |
Member
There was a problem hiding this comment.
🤖 [AI Review]
🟡 Suggestion: The enclosing TTSMode enum is already marked [Obsolete] / [EditorBrowsable(Never)], so repeating the attributes on each enum value is redundant — CS0618 already fires on any TTSMode.X access via the enum-level attribute. Same applies to every value of TTSState and to the PrevState / NextState properties inside the already-obsolete StateChangedEventArgs. Dropping the per-member copies removes ~30 lines of noise.
Suggested change
| /// </summary> | |
| [Obsolete("This has been deprecated in API14. Please use Tizen.Uix.Tts instead.")] | |
| [EditorBrowsable(EditorBrowsableState.Never)] | |
| Default = 0, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
[NUI] Deprecate NUI.TTSPlayer by TCSACR-649
API Changes
https://jira.sec.samsung.net/browse/TCSACR-649