[TCSACR-642][Tizen.Applications.ComponentBased.ComponentManager] Deprecate Component Manager APIs#7556
[TCSACR-642][Tizen.Applications.ComponentBased.ComponentManager] Deprecate Component Manager APIs#7556Hyeon-Uk wants to merge 3 commits intoSamsung:mainfrom
Conversation
Signed-off-by: Hyeon-Uk <rlagusdnr120@gmail.com>
Public API ChangedPlease follow the ACR process for the changed API below. Added: 0, Removed: 0, Changed: 28Changed/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentInfo
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Boolean Tizen.Applications.ComponentBased.ComponentInfo::IsIconDisplayed()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Boolean Tizen.Applications.ComponentBased.ComponentInfo::IsManagedByTaskManager()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentInfo::ApplicationId()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentInfo::ComponentId()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentInfo::IconPath()
/// <since_tizen>none</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentInfo::Label()
/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentType Tizen.Applications.ComponentBased.ComponentInfo::ComponentType()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentInfo::GetLocalizedLabel(System.String)
/// <privilege>http://tizen.org/privilege/packagemanager.info</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Void Tizen.Applications.ComponentBased.ComponentInfo::.ctor(System.String)
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Void Tizen.Applications.ComponentBased.ComponentInfo::Dispose()
/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentManager
/// <privilege>http://tizen.org/privilege/packagemanager.info</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
static System.Boolean Tizen.Applications.ComponentBased.ComponentManager::IsRunning(System.String)
/// <privilege>http://tizen.org/privilege/packagemanager.info</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
static System.Threading.Tasks.Task`1<System.Collections.Generic.IEnumerable`1<Tizen.Applications.ComponentBased.ComponentInfo>> Tizen.Applications.ComponentBased.ComponentManager::GetInstalledComponentsAsync()
/// <privilege>http://tizen.org/privilege/packagemanager.info</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
static System.Threading.Tasks.Task`1<System.Collections.Generic.IEnumerable`1<Tizen.Applications.ComponentBased.ComponentRunningContext>> Tizen.Applications.ComponentBased.ComponentManager::GetRunningComponentsAsync()
/// <privilege>http://tizen.org/privilege/appmanager.kill.bgapp</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
static System.Void Tizen.Applications.ComponentBased.ComponentManager::TerminateBackgroundComponent(Tizen.Applications.ComponentBased.ComponentRunningContext)
/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentRunningContext
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Boolean Tizen.Applications.ComponentBased.ComponentRunningContext::IsSubComponent()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Boolean Tizen.Applications.ComponentBased.ComponentRunningContext::IsTerminated()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentRunningContext::ApplicationId()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentRunningContext::ComponentId()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentRunningContext::InstanceId()
/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentRunningContext/ComponentState Tizen.Applications.ComponentBased.ComponentRunningContext::State()
/// <privilege>http://tizen.org/privilege/packagemanager.info</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Void Tizen.Applications.ComponentBased.ComponentRunningContext::.ctor(System.String)
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Void Tizen.Applications.ComponentBased.ComponentRunningContext::Dispose()
/// <privilege>http://tizen.org/privilege/appmanager.launch</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Void Tizen.Applications.ComponentBased.ComponentRunningContext::Resume()
/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentRunningContext/ComponentState
/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentType
Internal API ChangedAdded: 0, Removed: 0, Changed: 2Changed/// <privilege>http://tizen.org/privilege/appmanager.launch</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.Applications.ComponentBased.ComponentRunningContext::Pause()
/// <privilege>http://tizen.org/privilege/appmanager.launch</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.Applications.ComponentBased.ComponentRunningContext::Terminate()
|
Code Review1. Missing since_tizen tag on ComponentInfo.Label 2. Avoid marking Dispose() as Obsolete 3. Inconsistent deprecation message vs. related PR |
Added missing <since_tizen> 6 </since_tizen> tag to Label property in ComponentInfo. Removed incorrect [Obsolete] attributes from Dispose() methods in both ComponentInfo and ComponentRunningContext classes. Signed-off-by: Hyeon-Uk <rlagusdnr120@gmail.com>
Public API ChangedPlease follow the ACR process for the changed API below. Added: 0, Removed: 0, Changed: 26Changed/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentInfo
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Boolean Tizen.Applications.ComponentBased.ComponentInfo::IsIconDisplayed()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Boolean Tizen.Applications.ComponentBased.ComponentInfo::IsManagedByTaskManager()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentInfo::ApplicationId()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentInfo::ComponentId()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentInfo::IconPath()
- /// <since_tizen>none</since_tizen
+ /// <since_tizen>6</since_tizen
[Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentInfo::Label()
/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentType Tizen.Applications.ComponentBased.ComponentInfo::ComponentType()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentInfo::GetLocalizedLabel(System.String)
/// <privilege>http://tizen.org/privilege/packagemanager.info</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Void Tizen.Applications.ComponentBased.ComponentInfo::.ctor(System.String)
/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentManager
/// <privilege>http://tizen.org/privilege/packagemanager.info</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
static System.Boolean Tizen.Applications.ComponentBased.ComponentManager::IsRunning(System.String)
/// <privilege>http://tizen.org/privilege/packagemanager.info</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
static System.Threading.Tasks.Task`1<System.Collections.Generic.IEnumerable`1<Tizen.Applications.ComponentBased.ComponentInfo>> Tizen.Applications.ComponentBased.ComponentManager::GetInstalledComponentsAsync()
/// <privilege>http://tizen.org/privilege/packagemanager.info</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
static System.Threading.Tasks.Task`1<System.Collections.Generic.IEnumerable`1<Tizen.Applications.ComponentBased.ComponentRunningContext>> Tizen.Applications.ComponentBased.ComponentManager::GetRunningComponentsAsync()
/// <privilege>http://tizen.org/privilege/appmanager.kill.bgapp</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
static System.Void Tizen.Applications.ComponentBased.ComponentManager::TerminateBackgroundComponent(Tizen.Applications.ComponentBased.ComponentRunningContext)
/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentRunningContext
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Boolean Tizen.Applications.ComponentBased.ComponentRunningContext::IsSubComponent()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Boolean Tizen.Applications.ComponentBased.ComponentRunningContext::IsTerminated()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentRunningContext::ApplicationId()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentRunningContext::ComponentId()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentRunningContext::InstanceId()
/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentRunningContext/ComponentState Tizen.Applications.ComponentBased.ComponentRunningContext::State()
/// <privilege>http://tizen.org/privilege/packagemanager.info</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Void Tizen.Applications.ComponentBased.ComponentRunningContext::.ctor(System.String)
/// <privilege>http://tizen.org/privilege/appmanager.launch</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Void Tizen.Applications.ComponentBased.ComponentRunningContext::Resume()
/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentRunningContext/ComponentState
/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentType
Internal API ChangedAdded: 0, Removed: 0, Changed: 2Changed/// <privilege>http://tizen.org/privilege/appmanager.launch</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.Applications.ComponentBased.ComponentRunningContext::Pause()
/// <privilege>http://tizen.org/privilege/appmanager.launch</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void Tizen.Applications.ComponentBased.ComponentRunningContext::Terminate()
|
|
🤖 [AI Review] — [TCSACR-642] Deprecate ComponentManager APIs Suggestion: Inconsistent This PR uses Suggestion: Deprecation message should include migration guidance The [Obsolete("Deprecated since API14. This API will be removed in a future release.")]If there is a recommended replacement type or method, please include it in the message so developers have actionable migration guidance directly in IntelliSense. Note: Good fix — The |
|
🤖 [AI Review] — Follow-up on @JoonghyunCho review (unanswered) The review posted on this PR raised three issues. Checking the current diff for resolution status: 1. Missing 2. 3. Inconsistent deprecation message — ❌ Still present @Hyeon-Uk Could you please address items 2 and 3, and confirm the current state? |
Deprecated since API level 14 -> This has been deprecated in API14 Signed-off-by: Hyeon-Uk <rlagusdnr120@gmail.com>
Public API ChangedPlease follow the ACR process for the changed API below. Added: 0, Removed: 5, Changed: 26Removed- /// <since_tizen>9</since_tizen
- Tizen.Applications.ResourceControl
- /// <since_tizen>9</since_tizen
- System.Boolean Tizen.Applications.ResourceControl::IsAutoClose()
- /// <since_tizen>9</since_tizen
- System.String Tizen.Applications.ResourceControl::MaxResourceVersion()
- /// <since_tizen>9</since_tizen
- System.String Tizen.Applications.ResourceControl::MinResourceVersion()
- /// <since_tizen>9</since_tizen
- System.String Tizen.Applications.ResourceControl::ResourceType()
Changed/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentInfo
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Boolean Tizen.Applications.ComponentBased.ComponentInfo::IsIconDisplayed()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Boolean Tizen.Applications.ComponentBased.ComponentInfo::IsManagedByTaskManager()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentInfo::ApplicationId()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentInfo::ComponentId()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentInfo::IconPath()
- /// <since_tizen>none</since_tizen
+ /// <since_tizen>6</since_tizen
[Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentInfo::Label()
/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentType Tizen.Applications.ComponentBased.ComponentInfo::ComponentType()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentInfo::GetLocalizedLabel(System.String)
/// <privilege>http://tizen.org/privilege/packagemanager.info</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Void Tizen.Applications.ComponentBased.ComponentInfo::.ctor(System.String)
/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentManager
/// <privilege>http://tizen.org/privilege/packagemanager.info</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
static System.Boolean Tizen.Applications.ComponentBased.ComponentManager::IsRunning(System.String)
/// <privilege>http://tizen.org/privilege/packagemanager.info</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
static System.Threading.Tasks.Task`1<System.Collections.Generic.IEnumerable`1<Tizen.Applications.ComponentBased.ComponentInfo>> Tizen.Applications.ComponentBased.ComponentManager::GetInstalledComponentsAsync()
/// <privilege>http://tizen.org/privilege/packagemanager.info</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
static System.Threading.Tasks.Task`1<System.Collections.Generic.IEnumerable`1<Tizen.Applications.ComponentBased.ComponentRunningContext>> Tizen.Applications.ComponentBased.ComponentManager::GetRunningComponentsAsync()
/// <privilege>http://tizen.org/privilege/appmanager.kill.bgapp</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
static System.Void Tizen.Applications.ComponentBased.ComponentManager::TerminateBackgroundComponent(Tizen.Applications.ComponentBased.ComponentRunningContext)
/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentRunningContext
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Boolean Tizen.Applications.ComponentBased.ComponentRunningContext::IsSubComponent()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Boolean Tizen.Applications.ComponentBased.ComponentRunningContext::IsTerminated()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentRunningContext::ApplicationId()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentRunningContext::ComponentId()
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.String Tizen.Applications.ComponentBased.ComponentRunningContext::InstanceId()
/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentRunningContext/ComponentState Tizen.Applications.ComponentBased.ComponentRunningContext::State()
/// <privilege>http://tizen.org/privilege/packagemanager.info</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Void Tizen.Applications.ComponentBased.ComponentRunningContext::.ctor(System.String)
/// <privilege>http://tizen.org/privilege/appmanager.launch</privilege
/// <since_tizen>6</since_tizen
+ [Obsolete]
System.Void Tizen.Applications.ComponentBased.ComponentRunningContext::Resume()
/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentRunningContext/ComponentState
/// <since_tizen>6</since_tizen
+ [Obsolete]
Tizen.Applications.ComponentBased.ComponentType
Internal API ChangedAdded: 121, Removed: 0, Changed: 2 |
I removed that '[Obsolete]' annotation on |
https://jira.sec.samsung.net/browse/TCSACR-642