Repository navigation
Override vulnerable grpc-js and uuid in rules tests - #65
Merged
Merged
Conversation
Dependabot could not fix three alerts in the Firestore rules test tooling: @firebase/firestore pins @grpc/grpc-js ~1.9 (fixed in 1.13.6) and gaxios pins uuid ^9 (fixed in 11.1.1). npm overrides now force the patched versions. The uuid override is scoped to gaxios, since universal-analytics already uses uuid 14. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three Dependabot alerts stayed open, and Dependabot's own update jobs failed on them ("the available update path still resolves it to 9.0.1"):
@grpc/grpc-js1.9.16, fixed in 1.13.6@firebase/firestorepins~1.9.0uuid9.0.1, fixed in 11.1.1gaxiospins^9.0.1This only affects the Firestore rules test tooling in
firebase/firestore/test. None of it ships in the app.Change
overridesinfirebase/firestore/test/package.json:@grpc/grpc-js:^1.13.6, now 1.14.5 everywhere;gaxios→uuid:^11.1.1. Scoped togaxiosbecauseuniversal-analyticsalready usesuuid14 and a global override would break it.Verification
npm ls: no invalid packages.npm audit: 16 → 9 findings, withgrpc-jsanduuidgone. The 9 left were already onmainand are all insidefirebase-tools, the Firebase CLI:basic-ftp,@opentelemetry/core,braces(which has no fix yet). GitHub doesn't flag them, and they need afirebase-toolsrelease.grpc-js, so the override is exercised for real.🤖 Generated with Claude Code