Remove PDF gen#426
Open
SteveLLamb wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the tooling-based PDF rendering pipeline. HTML is the authoritative version of
SMPTE Engineering Documents; the generated PDF was convenience-only and consistently low
quality. Anyone who needs a PDF can use their browser's Print to PDF. This implements
the direction agreed in #407.
What changed
scripts/build.mjs): removed themakePDF()Puppeteer +paged.js renderer, the PDF filename assembly, and all PDF plumbing — review-link entry,
S3 URL, review-zip file, artifact link, and the
application/pdfmanifest entry (~108 lines).smpte.js): the?media=printdebug paththat pulled
paged.polyfill.jsfrom a CDN is gone.doc/main.html): reworded thetbodypage-break note from "when generatingPDF" to "when printing."
Also on this branch:
css/smpte.css): the equation is now centered to the page with thenumber right-aligned at the margin (3-column grid).
smpte.js): replaced literal smart-punctuation codepoints (curlyapostrophes,
©, em dashes) with straight characters / references, in line withILLEGAL_CHARS_RE.Print CSS
The print stylesheet is kept as-is — the
@media print/@pagerules andbreak-*hintsremain so browser Print to PDF still produces sensible page breaks. Running headers/footers
are now browser-native rather than paged.js-driven.
Verification
npm test(validation suite) — passes.node --checkpasses forbuild.mjsandsmpte.js; module imports resolve.makePDF/pagedjs/application/pdfreferences.toolingsubmodule at this change and running a full publish build — produces the rendered HTML
and zips with no PDF and no Puppeteer PDF pass.
See SMPTE/tst123-4-private#1 (
test PDF gen removal, commit3e8008f).Issues
Closes #407
Resolved by retiring the PDF tooling:
Partially addressed — PDF rendering is removed, but the HTML-side issue remains open: