fix(managed-context): correct namespace context calculation for multi-package#3988
Open
jstvz wants to merge 3 commits into
Open
fix(managed-context): correct namespace context calculation for multi-package#3988jstvz wants to merge 3 commits into
jstvz wants to merge 3 commits into
Conversation
…-package Centralize managed-mode determination into `determine_managed_mode()` utility. Fix installed_packages dict to also index by package Name. Fix ___NAMESPACED_ORG___ token replacement in package.xml. Includes lint fixes and test fixture updates for compatibility with the new installed_packages keys. Co-authored-by: Jorge Soler <jsolerburguera@salesforce.com>
Only access org_config.installed_packages when namespace or package_name is set. Prevents unnecessary API calls in tasks where no namespace context applies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of #3906 by @jorgesolebur with fixes for lint, test compatibility, and a backward-compat fix for task-level
namespaceoption fallback.determine_managed_mode()incumulusci/core/utils.pyinstalled_packagesby package Name in addition to namespace and ID___NAMESPACED_ORG___token replacement in package.xmloptions["namespace"]when project config namespace is unsetCloses #3906
Test plan
Co-authored-by: Jorge Soler jsolerburguera@salesforce.com