Skip to content

fix(ui): processing service details link and endpoint URL in form #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mihow merged 5 commits into from
Apr 1, 2026
Merged

fix(ui): processing service details link and endpoint URL in form #1198

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
037ef14
feat(ui): add project context to processing service details and optio…
mihow Apr 1, 2026
f399c4d
fix(ui): reformat with prettier 2.8.4 to match CI
mihow Apr 1, 2026
8cbd437
fix: normalize empty endpoint_url to null across frontend and backend
mihow Apr 1, 2026
c81b429
fix: replace save() guard with data migration for empty endpoint_url
mihow Apr 1, 2026
14e92c7
fix(ui): add null to EntityFieldValues customFields type
mihow Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ui/src/data-services/hooks/processing-services/useProcessingServiceDetails.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,19 @@ const convertServerRecord = (record: ServerProcessingService) =>
new ProcessingService(record)

export const useProcessingServiceDetails = (
processingServiceId: string
processingServiceId: string,
projectId?: string
): {
processingService?: ProcessingService
isLoading: boolean
isFetching: boolean
error?: unknown
} => {
const params = projectId ? `?project_id=${projectId}` : ''
const { data, isLoading, isFetching, error } =
useAuthorizedQuery<ProcessingService>({
queryKey: [API_ROUTES.PROCESSING_SERVICES, processingServiceId],
url: `${API_URL}/${API_ROUTES.PROCESSING_SERVICES}/${processingServiceId}`,
queryKey: [API_ROUTES.PROCESSING_SERVICES, processingServiceId, projectId],
url: `${API_URL}/${API_ROUTES.PROCESSING_SERVICES}/${processingServiceId}/${params}`,
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
})

const processingService = useMemo(
Expand Down
4 changes: 3 additions & 1 deletion ui/src/data-services/models/processing-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,9 @@ export class ProcessingService extends Entity {
color: string
} {
if (this.isAsync) {
return ProcessingService.getStatusInfo('UNKNOWN')
// Async services derive status from heartbeat
const status_code = this.lastSeenLive ? 'ONLINE' : 'UNKNOWN'
return ProcessingService.getStatusInfo(status_code)
}
const status_code = this.lastSeenLive ? 'ONLINE' : 'OFFLINE'
return ProcessingService.getStatusInfo(status_code)
Expand Down
2 changes: 1 addition & 1 deletion ui/src/pages/processing-service-details/processing-service-details-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const ProcessingServiceDetailsDialog = ({ id }: { id: string }) => {
const navigate = useNavigate()
const { projectId } = useParams()
const { processingService, isLoading, error } =
useProcessingServiceDetails(id)
useProcessingServiceDetails(id, projectId)
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

return (
<Dialog.Root
Expand Down
6 changes: 2 additions & 4 deletions ui/src/pages/project/entities/details-form/processing-service-details-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,8 @@ const config: FormConfig = {
},
endpoint_url: {
label: 'Endpoint URL',
description: 'Processing service endpoint.',
rules: {
required: true,
},
description:
'Processing service endpoint. Leave empty for pull-mode services that register themselves.',
},
Comment thread
mihow marked this conversation as resolved.
description: {
label: translate(STRING.FIELD_LABEL_DESCRIPTION),
Expand Down
Loading