Update library to work with current version of Phoenix#5
Open
joelekstrom wants to merge 6 commits into
Open
Conversation
Contributor
|
@accatyyc Please don't be sorry at all 😊 You got it done faster than I did 🙌 I will play with this later today! Thanks so much! |
Author
|
Oh that's right - I also added a mechanism to handle message replies with a block callback. - (void)sendEvent:(NSString*)event payload:(id)payload onReply:(HandleReplyBlock)handleReplyBlock;This might actually break compatibility with current clients. It's easily fixed by adding back the same method without the last argument though. I can fix that if you feel that it's important! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm sorry I haven't submitted this earlier, but here goes:
This updates the lib to work with the current version of Phoenix. For example, it's now called
phx_joininstead ofjoin, and also all messages now need a unique number calledref.Some crashes related to non-nilled pointers were fixed as well.
Thanks for the library!