Skip to content

Update library to work with current version of Phoenix#5

Open
joelekstrom wants to merge 6 commits into
RokkinCat:masterfrom
forzafootball:phoenix-compatibility
Open

Update library to work with current version of Phoenix#5
joelekstrom wants to merge 6 commits into
RokkinCat:masterfrom
forzafootball:phoenix-compatibility

Conversation

@joelekstrom

Copy link
Copy Markdown

I'm sorry I haven't submitted this earlier, but here goes:

This updates the lib to work with the current version of Phoenix. For example, it's now called phx_join instead of join, and also all messages now need a unique number called ref.

Some crashes related to non-nilled pointers were fixed as well.

Thanks for the library!

@joshdholtz

Copy link
Copy Markdown
Contributor

@accatyyc Please don't be sorry at all 😊 You got it done faster than I did 🙌 I will play with this later today! Thanks so much!

@joelekstrom

Copy link
Copy Markdown
Author

Oh that's right - I also added a mechanism to handle message replies with a block callback.

- (void)sendEvent:(NSString*)event payload:(id)payload onReply:(HandleReplyBlock)handleReplyBlock;

This might actually break compatibility with current clients. It's easily fixed by adding back the same method without the last argument though. I can fix that if you feel that it's important!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants