fix: message parser breaking workspace

apps/meteor/client/components/message/content/attachments/QuoteAttachment.tsx

@@ -13,6 +13,7 @@ import AttachmentAuthorName from './structure/AttachmentAuthorName';
 import AttachmentContent from './structure/AttachmentContent';
 import AttachmentDetails from './structure/AttachmentDetails';
 import AttachmentInner from './structure/AttachmentInner';
+import { useMaxMessageParseSize } from '../../hooks/useMaxMessageParseSize';
 
 // TODO: remove this team collaboration
 const quoteStyles = css`
@@ -38,6 +39,7 @@ type QuoteAttachmentProps = {
 export const QuoteAttachment = ({ attachment }: QuoteAttachmentProps): ReactElement => {
 	const formatTime = useTimeAgo();
 	const displayAvatarPreference = useUserPreference<boolean>('displayAvatars');
+	const maxMessageParseSize = useMaxMessageParseSize();
 
 	return (
 		<>
@@ -71,7 +73,11 @@ export const QuoteAttachment = ({ attachment }: QuoteAttachmentProps): ReactElem
 							<Attachments attachments={attachment.attachments} id={attachment.attachments[0]?.title_link} />
 						</AttachmentInner>
 					)}
-					{attachment.md ? <MessageContentBody md={attachment.md} /> : attachment.text.substring(attachment.text.indexOf('\n') + 1)}
+					{attachment.text?.length <= maxMessageParseSize && attachment.md ? (
+						<MessageContentBody md={attachment.md} />
+					) : (
+						attachment.text.substring(attachment.text.indexOf('\n') + 1)
+					)}
 				</AttachmentDetails>
 			</AttachmentContent>
 		</>

apps/meteor/client/components/message/hooks/useMaxMessageParseSize.ts

@@ -0,0 +1,18 @@
+import { useSetting } from '@rocket.chat/ui-contexts';
+import { useMemo } from 'react';
+
+import { MESSAGE_PARSE_HARD_LIMIT } from '../../../lib/constants';
+
+/**
+ * Returns the maximum allowed size for message parsing.
+ * Uses Math.min to ensure it never exceeds the hard limit to avoid performance issues.
+ * Always returns a number, never null or undefined.
+ */
+export const useMaxMessageParseSize = (): number => {
+	const settingValue = useSetting('Message_MaxAllowedSize', 5000);
+
+	return useMemo(() => {
+		const maxSize = typeof settingValue === 'number' ? settingValue : 5000;
+		return Math.min(maxSize, MESSAGE_PARSE_HARD_LIMIT);
+	}, [settingValue]);
+};

apps/meteor/client/components/message/hooks/useNormalizedMessage.ts

@@ -57,7 +57,7 @@ const normalizeAttachments = (attachments: MessageAttachment[], name?: string, t
 	});
 };
 
-export const useNormalizedMessage = <TMessage extends IMessage>(message: TMessage): MessageWithMdEnforced => {
+export const useNormalizedMessage = <TMessage extends IMessage>(message: TMessage, maxMessageParseSize: number): MessageWithMdEnforced => {
 	const katex = useMessageListKatex();
 	const katexEnabled = !!katex;
 	const customDomains = useAutoLinkDomains();
@@ -77,6 +77,19 @@ export const useNormalizedMessage = <TMessage extends IMessage>(message: TMessag
 			}),
 		};
 
+		if (message.msg && message.msg.length > maxMessageParseSize) {
+			return {
+				...message,
+				md: [
+					{
+						type: 'PARAGRAPH',
+						value: [{ type: 'PLAIN_TEXT', value: message.msg }],
+					},
+				],
+				attachments: message.attachments,
+			};
+		}
+
 		const normalizedMessage = parseMessageTextToAstMarkdown(message, parseOptions, autoTranslateOptions);
 
 		if (normalizedMessage.attachments) {
@@ -88,5 +101,14 @@ export const useNormalizedMessage = <TMessage extends IMessage>(message: TMessag
 		}
 
 		return normalizedMessage;
-	}, [showColors, customDomains, katexEnabled, katex?.dollarSyntaxEnabled, katex?.parenthesisSyntaxEnabled, message, autoTranslateOptions]);
+	}, [
+		showColors,
+		customDomains,
+		katexEnabled,
+		katex?.dollarSyntaxEnabled,
+		katex?.parenthesisSyntaxEnabled,
+		message,
+		autoTranslateOptions,
+		maxMessageParseSize,
+	]);
 };

apps/meteor/client/components/message/variants/ThreadMessagePreview.tsx

@@ -31,6 +31,7 @@ import { useGoToThread } from '../../../views/room/hooks/useGoToThread';
 import Emoji from '../../Emoji';
 import { useShowTranslated } from '../list/MessageListContext';
 import ThreadMessagePreviewBody from './threadPreview/ThreadMessagePreviewBody';
+import { useMaxMessageParseSize } from '../hooks/useMaxMessageParseSize';
 
 type ThreadMessagePreviewProps = {
 	message: IThreadMessage;
@@ -51,7 +52,9 @@ const ThreadMessagePreview = ({ message, showUserAvatar, sequential, ...props }:
 	useCountSelected();
 
 	const messageType = parentMessage.isSuccess ? MessageTypes.getType(parentMessage.data) : null;
-	const messageBody = useMessageBody(parentMessage.data);
+
+	const maxMessageParseSize = useMaxMessageParseSize();
+	const messageBody = useMessageBody(parentMessage.data, maxMessageParseSize);
 
 	const previewMessage = isParsedMessage(messageBody) ? { md: messageBody } : { msg: messageBody };
 

apps/meteor/client/components/message/variants/room/RoomMessageContent.tsx

@@ -18,6 +18,7 @@ import MessageActions from '../../content/MessageActions';
 import Reactions from '../../content/Reactions';
 import ThreadMetrics from '../../content/ThreadMetrics';
 import UrlPreviews from '../../content/UrlPreviews';
+import { useMaxMessageParseSize } from '../../hooks/useMaxMessageParseSize';
 import { useNormalizedMessage } from '../../hooks/useNormalizedMessage';
 import { useOembedLayout } from '../../hooks/useOembedLayout';
 import { useSubscriptionFromMessageQuery } from '../../hooks/useSubscriptionFromMessageQuery';
@@ -42,8 +43,9 @@ const RoomMessageContent = ({ message, unread, all, mention, searchText }: RoomM
 	const messageUser = { ...message.u, roles: [], ...useUserPresence(message.u._id) };
 	const chat = useChat();
 	const { t } = useTranslation();
+	const maxMessageParseSize = useMaxMessageParseSize();
 
-	const normalizedMessage = useNormalizedMessage(message);
+	const normalizedMessage = useNormalizedMessage(message, maxMessageParseSize);
 	const isMessageEncrypted = encrypted && normalizedMessage?.e2e === 'pending';
 
 	const quotes = normalizedMessage?.attachments?.filter(isQuoteAttachment) || [];

apps/meteor/client/components/message/variants/thread/ThreadMessageContent.tsx

@@ -15,6 +15,7 @@ import Location from '../../content/Location';
 import MessageActions from '../../content/MessageActions';
 import Reactions from '../../content/Reactions';
 import UrlPreviews from '../../content/UrlPreviews';
+import { useMaxMessageParseSize } from '../../hooks/useMaxMessageParseSize';
 import { useNormalizedMessage } from '../../hooks/useNormalizedMessage';
 import { useOembedLayout } from '../../hooks/useOembedLayout';
 import { useSubscriptionFromMessageQuery } from '../../hooks/useSubscriptionFromMessageQuery';
@@ -33,10 +34,11 @@ const ThreadMessageContent = ({ message }: ThreadMessageContentProps): ReactElem
 	const uid = useUserId();
 	const { enabled: readReceiptEnabled } = useMessageListReadReceipts();
 	const messageUser = { ...message.u, roles: [], ...useUserPresence(message.u._id) };
+	const maxMessageParseSize = useMaxMessageParseSize();
 
 	const { t } = useTranslation();
 
-	const normalizedMessage = useNormalizedMessage(message);
+	const normalizedMessage = useNormalizedMessage(message, maxMessageParseSize);
 
 	const isMessageEncrypted = encrypted && normalizedMessage?.e2e === 'pending';
 

apps/meteor/client/lib/constants.ts

@@ -3,3 +3,4 @@ export const BIO_TEXT_MAX_LENGTH = 260;
 export const VIDEOCONF_STACK_MAX_USERS = 6;
 export const NAVIGATION_REGION_ID = 'navigation-region';
 export const MAX_FILE_SIZE_PREVIEW = 10485760; // 10MB
+export const MESSAGE_PARSE_HARD_LIMIT = 10000;

apps/meteor/client/views/room/MessageList/hooks/useMessageBody.tsx

@@ -6,7 +6,7 @@ import { useAutoLinkDomains } from './useAutoLinkDomains';
 import { useMessageListAutoTranslate } from '../../../../components/message/list/MessageListContext';
 import { parseMessageTextToAstMarkdown } from '../../../../lib/parseMessageTextToAstMarkdown';
 
-export const useMessageBody = (message: IMessage | undefined): string | Root => {
+export const useMessageBody = (message: IMessage | undefined, maxMessageParseSize: number): string | Root => {
 	const autoTranslateOptions = useMessageListAutoTranslate();
 	const customDomains = useAutoLinkDomains();
 
@@ -15,6 +15,10 @@ export const useMessageBody = (message: IMessage | undefined): string | Root =>
 			return '';
 		}
 
+		if (message.msg && message.msg.length > maxMessageParseSize) {
+			return message.msg;
+		}
+
 		if (message.md) {
 			const parseOptions: Options = {
 				customDomains,
@@ -39,5 +43,5 @@ export const useMessageBody = (message: IMessage | undefined): string | Root =>
 		}
 
 		return '';
-	}, [message, customDomains, autoTranslateOptions]);
+	}, [message, customDomains, autoTranslateOptions, maxMessageParseSize]);
 };