regression: timezone field blank for legacy aliases#40305
regression: timezone field blank for legacy aliases#40305dougfabris wants to merge 2 commits intorelease-8.4.0from
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-8.4.0 #40305 +/- ##
=================================================
+ Coverage 69.74% 69.97% +0.22%
=================================================
Files 3298 3299 +1
Lines 119292 120106 +814
Branches 21469 21499 +30
=================================================
+ Hits 83206 84043 +837
+ Misses 32785 32776 -9
+ Partials 3301 3287 -14
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Summary
Restores compatibility for legacy timezone aliases (
UTC,Etc/UTC,US/Pacific,Japan, …) that were lost when #40076 migrated the timezone list frommoment.tz.names()(597 zones) toIntl.supportedValuesOf('timeZone')(418 zones). AnySelectfed byuseTimezoneNameList— Business Hours and the admin Timezone setting — rendered empty for workspaces whose saved value was one of the 179 dropped aliases.canonicalizeTimezonein@rocket.chat/tools— resolves legacy aliases to their canonical IANA zone viaIntl.DateTimeFormat, falling back to the input on invalid values.UTCis always present inuseTimezoneNameList, sinceIntl.supportedValuesOfomits it on several ICU versions.EditBusinessHoursandSelectTimezoneSettingInput, so existing documents render correctly and are gradually rewritten to canonical form on save.Test plan
timezone.name === "UTC"(pre-8.4), open it on this branch — field showsUTC, save persistsUTC.US/Pacific— field showsAmerica/Los_Angeles, saves asAmerica/Los_Angeles.Issue(s)
Steps to test or reproduce
Further comments
CORE-2135