Skip to content

feat: Allow admins to use roles as abac attributes when using Rocket.Chat as PDP#40266

Draft
KevLehman wants to merge 12 commits intodevelopfrom
feat/abac-use-user-roles-as-attributes
Draft

feat: Allow admins to use roles as abac attributes when using Rocket.Chat as PDP#40266
KevLehman wants to merge 12 commits intodevelopfrom
feat/abac-use-user-roles-as-attributes

Conversation

@KevLehman
Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Apr 22, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9a23adee-aff9-41e7-aea9-9c7622df7204

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 22, 2026

⚠️ No Changeset found

Latest commit: 8512432

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 66.01942% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.85%. Comparing base (5cf4c7c) to head (8512432).
⚠️ Report is 10 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #40266      +/-   ##
===========================================
+ Coverage    69.82%   69.85%   +0.02%     
===========================================
  Files         3296     3300       +4     
  Lines       119173   119269      +96     
  Branches     21470    21497      +27     
===========================================
+ Hits         83213    83312      +99     
+ Misses       32656    32649       -7     
- Partials      3304     3308       +4     
Flag Coverage Δ
e2e 59.79% <ø> (+0.06%) ⬆️
e2e-api 47.13% <100.00%> (+0.95%) ⬆️
unit 70.56% <62.76%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant