Skip to content

Add RFC 6381 codec info BitDepth and PixelFormat to video-audit, bids-inject, and split-video #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vmdocua merged 4 commits into from
May 23, 2026
Merged

Add RFC 6381 codec info BitDepth and PixelFormat to video-audit, bids-inject, and split-video #254

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c2ed8f
Add additional attributes to AudioInfo model to generate codec in RFC…
vmdocua May 23, 2026
512468d
Add VideoInfo model to extract video stream information with ffprobe
vmdocua May 23, 2026
912ecc9
Add VideoCodecRFC6381 and AudioCodecRFC6381 to sidecar_metadata via f…
vmdocua May 23, 2026
9bf2e84
Add BitDepth and PixelFormat to BIDS sidecar JSON
vmdocua May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/reprostim/qr/video_audit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,13 @@ class AudioInfo(BaseModel):
bits_per_sample: Optional[int] = None # Bits per sample
channels: Optional[int] = None # Number of audio channels
codec: Optional[str] = None # Audio codec used
codec_long: Optional[str] = None # Audio codec detailed name
codec_rfc6381: Optional[str] = None # Audio codec in RFC 6381 format
duration_sec: Optional[float] = None # Duration in seconds
profile: Optional[str] = None # Audio codec profile (e.g., "LC")
sample_rate: Optional[int] = None # Sample rate in Hz
start_time: Optional[float] = None # Start time of the audio stream in seconds
tag_str: Optional[str] = None # Codec tag string (e.g., "[0][0][0][0]")
Comment on lines +62 to +68

@gemini-code-assist gemini-code-assist Bot May 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The addition of these fields to the AudioInfo model appears to be an incomplete implementation. While the fields are defined, they are not currently populated in the get_audio_info_ffprobe function (line 404), nor are they mapped to the VaRecord model or included in the do_audit_file logic (line 807). To achieve the stated goal of adding RFC 6381 codec info to the video audit, the extraction logic from ffprobe output and the subsequent mapping to the audit summary records should be implemented.



class VaMode(str, Enum):
Expand Down
Loading