Skip to content

GH-1307 Fix texture not appearing until restart#1309

Open
JoltedJon wants to merge 1 commit into
Redot-Engine:masterfrom
JoltedJon:GH-1307
Open

GH-1307 Fix texture not appearing until restart#1309
JoltedJon wants to merge 1 commit into
Redot-Engine:masterfrom
JoltedJon:GH-1307

Conversation

@JoltedJon

@JoltedJon JoltedJon commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

fixes #1307

The guard for this only checked for AtlasTexture but if other types of textures were inputted in it would not connect the function to cause it to be updated.

Summary by CodeRabbit

  • Bug Fixes
    • Improved atlas texture updates when switching between different atlas resources.
    • Ensured change notifications are correctly disconnected from the previous atlas and connected to the newly assigned one.

@JoltedJon
JoltedJon requested review from a team July 15, 2026 15:25
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a883a0f4-3260-472b-8eed-091b9b5bac01

📥 Commits

Reviewing files that changed from the base of the PR and between 44ce9f4 and 4fd3234.

📒 Files selected for processing (1)
  • scene/resources/atlas_texture.cpp

Walkthrough

AtlasTexture::set_atlas now disconnects the change callback from any previously valid atlas resource and connects it to any newly assigned valid atlas resource.

Changes

Atlas signal wiring

Layer / File(s) Summary
Atlas resource signal handling
scene/resources/atlas_texture.cpp
set_atlas broadens signal disconnection to valid resources and uses the assigned atlas validity check when connecting the callback.

Estimated code review effort: 2 (Simple) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main fix: AtlasTexture textures not appearing until restart.
Linked Issues check ✅ Passed The code change matches issue #1307 by fixing signal wiring so atlas texture updates propagate immediately.
Out of Scope Changes check ✅ Passed The PR is narrowly scoped to atlas texture signal handling and adds no unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Shakai-Dev Shakai-Dev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Open

Development

Successfully merging this pull request may close these issues.

Atlas texture not appearing on MeshInstance3D until project saved & restarted

2 participants