RDSC-3561 Add custom keystore and truststore for the jedis client in redis sink - #3
Open
nange10v wants to merge 1 commit into
Open
RDSC-3561 Add custom keystore and truststore for the jedis client in redis sink#3nange10v wants to merge 1 commit into
nange10v wants to merge 1 commit into
Conversation
…or the jedis client in redis sink
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for custom SSL configurations for the Jedis client in the Redis sink. It introduces new configuration options for specifying custom keystore and truststore settings, updates the Redis client connection logic, and bumps the Jedis dependency version to 6.0.0.
- The Redis connection constructors in both the offset store and schema history have been updated to use a unified configuration object.
- New configuration fields and accessors for truststore and keystore properties have been added in the common configuration.
- The SSL configuration in the Redis connection now optionally applies custom SslOptions when needed.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| RedisOffsetBackingStore.java | Updated to use the new RedisConnection constructor with configuration object. |
| RedisSchemaHistory.java | Updated to use the new RedisConnection constructor with configuration object. |
| RedisConnection.java | Refactored to use final fields, added support for custom SSL options with keystore/truststore, and adjusted SSL parameter configuration. |
| RedisCommonConfig.java | Added new fields and accessors for custom truststore/keystore settings. |
| pom.xml | Jedis version updated from 4.1.1 to 6.0.0 to support the new SSL options. |
nange10v
marked this pull request as ready for review
May 13, 2025 10:09
peperon
approved these changes
May 13, 2025
stoyanr
requested changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces additional configuration options for specifying custom keystore/truststore for the jedis client in redis sink. This allows the client to use different keys and certificates than the default ones passed to the JVM.
This change updates the Jedis client to version 6.0.0. and takes advantage of the newly introduced SSL options.
The options are applied only if
redis.ssl.enabledis true.Configuration properties for each new SSL options:
redis.ssl.truststore.path: Specifies the path to the truststore file used for SSL.redis.ssl.truststore.password: Specifies the password for the truststore file.redis.ssl.truststore.type: Specifies the type of the truststore (e.g., JKS, PKCS12) (default: JKS).redis.ssl.keystore.path: Specifies the path to the keystore file used for SSL.redis.ssl.keystore.password: Specifies the password for the keystore file.redis.ssl.keystore.type: Specifies the type of the keystore (e.g., JKS, PKCS12) (default: JKS).see https://redislabs.atlassian.net/browse/RDSC-3561