Skip to content

abstract success criteria constants and magic strings - #1814

Merged
dapomeroy merged 1 commit into
Ramble-Project:developfrom
rfbgo:success_criteria_constants
Sep 29, 2026
Merged

dapomeroy merged 1 commit into
Ramble-Project:developfrom
rfbgo:success_criteria_constants

Conversation

@rfbgo

@rfbgo rfbgo commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Bob <robertbird@google.com>
@rfbgo
rfbgo force-pushed the success_criteria_constants branch from d2499e4 to 88910f8 Compare September 29, 2026 14:07
@ramble-project-pr-bot

ramble-project-pr-bot Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Ramble Performance Test Metrics

Results produced with commit: 88910f8

Test Name Outcome Duration (s) Most Recent Run (s) Last 5 Avg (s)
test_analyze_large_file passed 1.0667 1.0725 (dff2e37) 1.0519
test_large_template_expansion passed 1.2098 1.2142 (dff2e37) 1.2073
test_many_experiments passed 29.9664 29.8921 (dff2e37) 30.4717
test_many_objects_defaults passed 15.7627 16.2349 (dff2e37) 16.3540
test_matrix_filter_perf passed 1.0788 1.0832 (dff2e37) 1.0949

@rfbgo
rfbgo requested a review from dapomeroy September 29, 2026 14:20
@codecov

codecov Bot commented Sep 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Comment thread lib/ramble/ramble/success_criteria.py
@dapomeroy
dapomeroy merged commit ce64f8f into Ramble-Project:develop Sep 29, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants