Skip to content

cleanup keyword magic strings - #1812

Merged
linsword13 merged 1 commit into
Ramble-Project:developfrom
rfbgo:keywords_variants_cleanup
Sep 29, 2026
Merged

linsword13 merged 1 commit into
Ramble-Project:developfrom
rfbgo:keywords_variants_cleanup

Conversation

@rfbgo

@rfbgo rfbgo commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@rfbgo
rfbgo force-pushed the keywords_variants_cleanup branch from df820c9 to 2bdd828 Compare September 28, 2026 17:31
@rfbgo
rfbgo requested a review from linsword13 September 28, 2026 17:31
@ramble-project-pr-bot

ramble-project-pr-bot Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Ramble Performance Test Metrics

Results produced with commit: fb24247

Test Name Outcome Duration (s) Most Recent Run (s) Last 5 Avg (s)
test_analyze_large_file passed 1.0684 1.0242 (a13f2f8) 1.0439
test_large_template_expansion passed 1.2095 1.1858 (a13f2f8) 1.2074
test_many_experiments passed 29.7301 28.8925 (a13f2f8) 30.3946
test_many_objects_defaults passed 16.3296 15.5758 (a13f2f8) 16.3448
test_matrix_filter_perf passed 1.0919 1.0683 (a13f2f8) 1.0966

@rfbgo
rfbgo force-pushed the keywords_variants_cleanup branch from 2bdd828 to 46dc223 Compare September 28, 2026 18:43
Signed-off-by: Bob <robertbird@google.com>
@rfbgo
rfbgo force-pushed the keywords_variants_cleanup branch from 46dc223 to fb24247 Compare September 28, 2026 19:32
@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/ramble/ramble/keywords.py 90.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@linsword13
linsword13 merged commit dff2e37 into Ramble-Project:develop Sep 29, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants