workspace concretize: omit injected-if-missing packages and compilers by default - #1810
Merged
douglasjacobsen merged 1 commit intoOct 2, 2026
Conversation
Collaborator
|
/gcbrun |
Ramble Performance Test MetricsResults produced with commit: 6e6b810
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
chinglung880218
force-pushed
the
omit-injected-packages-concretize
branch
from
September 28, 2026 16:31
a63612a to
b0bff29
Compare
Collaborator
|
FYI I don't think your test failure here is caused by your code. See #1813 for details if curious, but I will try fix on develop and re-run |
Collaborator
|
/gcbrun |
chinglung880218
force-pushed
the
omit-injected-packages-concretize
branch
from
September 28, 2026 18:45
b0bff29 to
24d6924
Compare
Contributor
Author
|
Thanks for the fix! |
Collaborator
|
/gcbrun |
Signed-off-by: Ching-Lung Hsu <chinglunghsu@google.com>
chinglung880218
force-pushed
the
omit-injected-packages-concretize
branch
from
September 28, 2026 21:29
24d6924 to
6e6b810
Compare
Collaborator
|
/gcbrun |
douglasjacobsen
approved these changes
Oct 2, 2026
douglasjacobsen
left a comment
douglasjacobsen
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, this is really helpful!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when
workspace concretizeis executed, packages and compilers withinject_if_missing=True(from modifiers or systems) are written intoramble.yaml. Since Ramble injects these automatically at runtime anyway, persisting them clutters the configuration and can trigger false unused compiler warnings.This PR omits
inject_if_missingpackages and compilers fromramble.yamlby default, and adds an--include-injected-packagesflag toworkspace concretizeif users want to explicitly include them.It also improves compiler tracking to avoid false "Unused compiler" warnings for omitted compilers, while ensuring compilers from overridden injected specs are not incorrectly marked as used. Tests are included or adjusted correspondingly.