Replace live gcs fetch test with mocked - #1753
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the GCS fetch strategy tests by replacing the network-dependent test with a mocked implementation using custom mock classes (MockBlob, MockBucket, and MockGcsClient). Additionally, it introduces a new test, test_gcsfetchstrategy_content_type_mismatch, to ensure a warning is issued when there is a content type mismatch. There are no review comments, so I have no feedback to provide.
Ramble Performance Test MetricsResults produced with commit: 580d1b3
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1753 +/- ##
===========================================
+ Coverage 94.07% 94.09% +0.01%
===========================================
Files 370 370
Lines 37424 37463 +39
===========================================
+ Hits 35207 35251 +44
+ Misses 2217 2212 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@dcoapp recheck |
Signed-off-by: Bob <robertbird@google.com>
Previously we were hitting a live end point out of our control (
gs://hpc-toolkit-demos/build_cache/index.json), which means our unit tests required internet. This addresses those 2 issues