Skip to content

Remove wrappers to ramble.config.config.get.. in workspace - #1752

Open
rfbgo wants to merge 2 commits into
Ramble-Project:developfrom
rfbgo:no_workspace_conf
Open

Remove wrappers to ramble.config.config.get.. in workspace#1752
rfbgo wants to merge 2 commits into
Ramble-Project:developfrom
rfbgo:no_workspace_conf

Conversation

@rfbgo

@rfbgo rfbgo commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors workspace configuration retrieval by replacing class-specific getter methods with direct calls to ramble.config.get(), allowing the removal of several deprecated helper methods in the Workspace class. Feedback on these changes highlights a missing namespace import in google_batch.py that will cause a NameError, as well as multiple instances where using .copy() on configuration dictionaries creates a shallow copy, potentially leading to in-memory cache corruption. It is recommended to use copy.deepcopy() for these dictionaries.

Comment thread lib/ramble/ramble/workspace/workspace.py Outdated
Comment thread lib/ramble/ramble/workspace/workspace.py Outdated
Comment thread lib/ramble/ramble/workspace/workspace.py Outdated
@ramble-pr-bot

ramble-pr-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

Ramble Performance Test Metrics

Results produced with commit: 17aff2e

Test Name Outcome Duration (s) Most Recent Run (s) Last 5 Avg (s)
test_analyze_large_file passed 2.2750 2.0856 (b311f41) 2.0701
test_large_template_expansion passed 1.2742 1.2188 (b311f41) 1.1978
test_many_experiments passed 26.9163 25.3640 (b311f41) 24.4371
test_many_objects_defaults passed 14.3795 13.6953 (b311f41) 12.7329
test_matrix_filter_perf passed 1.2178 1.1669 (b311f41) 1.1093

@rfbgo

rfbgo commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors workspace configuration access across the codebase by replacing Workspace instance helper methods (such as get_workspace_vars() and get_software_dict()) with direct calls to ramble.config.get(). This allows for the removal of several redundant getter methods in the Workspace class. The review feedback highlights two critical issues: a missing import of namespace in google_batch.py that will cause a NameError, and a potential configuration cache corruption in workspace.py due to mutating full_software_dict in-place without deep-copying it.

Comment thread lib/ramble/ramble/workspace/workspace.py Outdated
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.06%. Comparing base (6d999da) to head (17aff2e).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1752      +/-   ##
===========================================
- Coverage    94.07%   94.06%   -0.01%     
===========================================
  Files          370      370              
  Lines        37399    37378      -21     
===========================================
- Hits         35182    35161      -21     
  Misses        2217     2217              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rfbgo
rfbgo force-pushed the no_workspace_conf branch from 620295b to dcfff90 Compare August 31, 2026 20:07
@rfbgo
rfbgo requested a review from douglasjacobsen August 31, 2026 20:58
@rfbgo
rfbgo force-pushed the no_workspace_conf branch from dcfff90 to 17aff2e Compare August 31, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant