[bench] vit_attention/bench.py: add --backend, default to running all#1044
Draft
mgehre-amd wants to merge 1 commit into
Draft
[bench] vit_attention/bench.py: add --backend, default to running all#1044mgehre-amd wants to merge 1 commit into
mgehre-amd wants to merge 1 commit into
Conversation
Add a --backend flag whose choices match the values accepted by --mm-encoder-attn-backend (TRITON_ATTN, TORCH_SDPA, FLASH_ATTN, ROCM_AITER_FA). The default value "all" runs every backend in sequence and emits one JSON line per backend so backends can be compared in a single invocation. Also sync the TRITON_ATTN launch with the current _fwd_kernel signature, which gained BLOCK_DMODEL_TAIL and HEAD_STRIDE_ALIGNED_8 since the script was first written. Use _split_head_dim() and get_block_n() from the production code so the tuning parameters are consistent. Co-authored-by: Claude Signed-off-by: Matthias Gehre <matthias.gehre@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a --backend flag whose choices match the values accepted by --mm-encoder-attn-backend (TRITON_ATTN, TORCH_SDPA, FLASH_ATTN, ROCM_AITER_FA). The default value "all" runs every backend in sequence and emits one JSON line per backend so backends can be compared in a single invocation.
Also sync the TRITON_ATTN launch with the current _fwd_kernel signature, which gained BLOCK_DMODEL_TAIL and HEAD_STRIDE_ALIGNED_8 since the script was first written. Use _split_head_dim() and get_block_n() from the production code so the tuning parameters are consistent.
Run via
benchmarks/vit_attention/bench.py --heads 16 --head-dim 64 --seq 784to get output like