[hip-tests] Move __hipGetPCH out of bit_extract and add some context - #1928
[hip-tests] Move __hipGetPCH out of bit_extract and add some context#1928jmmartinez wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR extracts the __hipGetPCH functionality test from the bit_extract sample into a dedicated test file, improving code organization and adding documentation about this legacy API.
Key changes:
- Created a new
get_hip_pchtest sample with proper context and documentation - Removed the unrelated
__hipGetPCHtest code frombit_extract - Added explanatory comments about the legacy nature and historical usage of the PCH API
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/hip-tests/samples/0_Intro/get_hip_pch/get_hip_pch.cpp | New test file dedicated to testing __hipGetPCH functionality with proper error checking and context |
| projects/hip-tests/samples/0_Intro/get_hip_pch/README.md | Documentation for the new get_hip_pch test |
| projects/hip-tests/samples/0_Intro/get_hip_pch/CMakeLists.txt | Build configuration for the new test |
| projects/hip-tests/samples/0_Intro/bit_extract/bit_extract.cpp | Removed unrelated __hipGetPCH test code |
| projects/hip-tests/samples/0_Intro/bit_extract/CMakeLists.txt | Removed PCH-related build configuration no longer needed |
| projects/hip-tests/samples/0_Intro/CMakeLists.txt | Added the new get_hip_pch subdirectory to the build |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d94f485 to
1f6e24a
Compare
Merge pull request #1928 from corey-derochie-amd/2.27.7-sync
|
@ROCm/hip-tests-reviewers ping :) |
@ROCm/hip-tests-reviewers ping :) |
e53c38b to
d7648a8
Compare
d7648a8 to
b62239d
Compare
|
This pull request has been inactive for 25 days and will be marked as stale. If you would like to keep this PR open, please:
This PR will be automatically closed in 5 days if no further activity occurs. |
|
This pull request has been automatically closed due to inactivity (30 days with no updates). If you'd like to continue working on this, feel free to reopen the PR or create a new one. |
Motivation
Currently there is a wild unrelated
__hipGetPCHcall inside thebit_extracttest.This function is pretty much legacy; but in the meantime, lets move it to its own test and not leave it polluting
bit_extract.This was originally submitted to ROCm/hip-tests#471 .