Respect MFMA arch disablement in CI - #2455
Open
justinrosner wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Jenkins pipeline logic for the mfma codepath so that MFMA CI jobs only run on explicitly enabled MFMA-capable architectures (gfx908/gfx90a/gfx942), matching existing “disable arch” behavior used elsewhere in the pipeline.
Changes:
- Add a helper to compute the set of enabled MFMA architectures from
disable908/disable90a/disable942. - Build the MFMA Jenkins node label dynamically from the enabled architecture set.
- Prevent MFMA codepath execution when all supported MFMA architectures are disabled.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1031
to
+1034
| def architectures = getEnabledMfmaArchitectures() | ||
| if (architectures.isEmpty()) { | ||
| error 'mfma codepath selected but all of gfx942/gfx908/gfx90a are disabled' | ||
| } |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2455 +/- ##
===========================================
+ Coverage 82.57% 83.59% +1.02%
===========================================
Files 120 121 +1
Lines 42852 43182 +330
Branches 7110 7181 +71
===========================================
+ Hits 35381 36095 +714
+ Misses 4815 4513 -302
+ Partials 2656 2574 -82
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Ensure PR and nightly MFMA CI jobs respect the architecture disable parameters. Previously, MFMA jobs could still run on any one of gfx908, gfx90a, or gfx942 even if those archs were explicitly disabled. This now matches the behavior that we can get for other archs (gfx950, Navi3x, etc.)
This is a port of https://github.com/ROCm/rocmlirTriton/pull/427 from rocmlirTriton.
Technical Details
NOTE: rocMLIR already respects these disable flags in
shouldRunFromChip()for chip specific tuning and performance matrix rows. However, build/test and other codepath-based rows still needed updating.Test Plan
Test Result
Submission Checklist