Skip to content

[Attention] Handle fully masked reference rows - #2448

Merged
umangyadav merged 5 commits into
developfrom
fix/fully-masked-attention
Aug 19, 2026
Merged

[Attention] Handle fully masked reference rows#2448
umangyadav merged 5 commits into
developfrom
fix/fully-masked-attention

add nrlargerthanthread test

893f0f5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 19, 2026 in 1s

83.72% (+1.16%) compared to e282b78

View this Pull Request on Codecov

83.72% (+1.16%) compared to e282b78

Details

Codecov Report

❌ Patch coverage is 96.96970% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
mlir/tools/rocmlir-gen/rocmlir-gen.cpp 95.45% 0 Missing and 2 partials ⚠️
...lect/Rock/Transforms/BlockwiseGemmToThreadwise.cpp 98.18% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2448      +/-   ##
===========================================
+ Coverage    82.57%   83.72%   +1.16%     
===========================================
  Files          120      121       +1     
  Lines        42852    43243     +391     
  Branches      7110     7185      +75     
===========================================
+ Hits         35381    36204     +823     
+ Misses        4815     4494     -321     
+ Partials      2656     2545     -111     
Files with missing lines Coverage Δ
...lect/Rock/Transforms/BlockwiseGemmToThreadwise.cpp 90.78% <98.18%> (+0.69%) ⬆️
mlir/tools/rocmlir-gen/rocmlir-gen.cpp 87.17% <95.45%> (+0.62%) ⬆️

... and 46 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.