[release/2.13] [ROCm] derive the hipcub compatible cccl version from 'HIPCUB_CCCL_VERSION'#3442
Open
jithunnair-amd wants to merge 1 commit into
Open
Conversation
…RSION' (pytorch#188072) # Context Recreated pytorch#184552 from personal fork. hipCUB is targeting to be compatible with CCCL 3.0 (ROCm/rocm-libraries#4079). This requires updating some of the CUB and hipCUB compatibility glue. To help this transition hipCUB will be exposing `HIPCUB_CCCL_VERSION` in one of the following ROCm releases (>=7.14) (ROCm/rocm-libraries#7632), which will be bumped once hipCUB reaches parity with CCCL 3.0 and beyond. This PR is created in anticipation for this future changes. # Implementation - Introduce dependency on [`libhipcxx`](https://github.com/ROCm/libhipcxx). - Guard `FpLimits` for `c10::BFloat16` backport to pre CCCL 3.x. Numeric limits are handled by libhipcxx. - Extend `CUB_VERSION` derivation for hipCUB. Keep old fallback for backwards compatibility. Only enable CUB V3 API once hipCUB reaches parity with CCCL 3.x. Pull Request resolved: pytorch#188072 Approved by: https://github.com/jeffdaily (cherry picked from commit c8e2473)
|
Jenkins build for b6b38c331bafd837c5fab5042312b20b7e9d22dd commit finished as FAILURE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of pytorch#188072 (commit c8e2473) onto
release/2.13.Summary
FpLimitsforc10::BFloat16backport to pre CCCL 3.xCUB_VERSIONderivation for hipCUB usingHIPCUB_CCCL_VERSIONNotes
Cherry-pick applied cleanly.
Test plan
Authored with assistance from Cursor
Made with Cursor