Test change for test_rocm_wheels enablement in rockrel - #7383
Conversation
There was a problem hiding this comment.
Always keep Linux and Windows workflows in sync: https://github.com/ROCm/TheRock/blob/main/.github/workflows/multi_arch_release_windows.yml
| workflow: test_rocm_wheels.yml | ||
| inputs: | | ||
| { "amdgpu_family": "${{ matrix.amdgpu_family }}", | ||
| "test_runs_on": "${{ matrix.test_runs_on }}", | ||
| "package_find_links_url": "${{ needs.build_python_packages.outputs.kpack_split == 'true' && needs.build_python_packages.outputs.package_find_links_url || format('{0}/{1}/index.html', needs.build_python_packages.outputs.package_find_links_url, matrix.amdgpu_family) }}", | ||
| "python_version": "${{ matrix.python_version }}", | ||
| "rocm_version": "${{ inputs.rocm_package_version }}", | ||
| "container_image_name": "${{ matrix.container_image_name }}", | ||
| "container_image_url": "${{ matrix.container_image_url }}", | ||
| "kpack_split": "${{ needs.build_python_packages.outputs.kpack_split }}" | ||
| } |
There was a problem hiding this comment.
Ah this isn't great - the matrix is going to dispatch lots of jobs here.
I would rather have releases dispatch closer to what test_artifacts does: one workflow run per amdgpu_family, not per [amdgpu_family, container, python_version].
Need to look at the workflow architecture a bit to see how we might simplify there.
There was a problem hiding this comment.
I haven't had much time to take a more detailed look here yet.
One idea would be to add a new workflow that takes fromJSON(inputs.build_config).test_python_packages_matrix as an input and have that workflow expand the matrix itself.
CI would run that new workflow here:
TheRock/.github/workflows/multi_arch_ci_linux.yml
Lines 285 to 313 in 4444ac2
We've gone through a few iterations on the workflow matrix shape, see also
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Motivation
Corresponding change to Therock so that wrapper test_rocm_wheels.yml for rockrel can be called ROCm/rockrel#84
Issue: ROCm/rockrel#82
Technical Details
modified .github/workflows/multi_arch_release_linux.yml to call
Test Plan
PASS multi arch release Linux Trigger Test Wheels:
https://github.com/ROCm/TheRock/actions/runs/31559471913
https://github.com/ROCm/TheRock/actions/runs/31583784516
Test Result
PASS
Submission Checklist