test(packaging): add uninstall test steps to the native Linux package installation test workflow - #7184
Open
arvindcheru wants to merge 8 commits into
Open
test(packaging): add uninstall test steps to the native Linux package installation test workflow#7184arvindcheru wants to merge 8 commits into
arvindcheru wants to merge 8 commits into
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
arvindcheru
force-pushed
the
users/acheruva/enable_uninstall_pkg_test
branch
from
August 10, 2026 21:52
3bca8dc to
49b356e
Compare
arvindcheru
force-pushed
the
users/acheruva/enable_uninstall_pkg_test
branch
from
August 10, 2026 22:40
49b356e to
9f2d8da
Compare
arvindcheru
marked this pull request as ready for review
August 10, 2026 22:44
arvindcheru
force-pushed
the
users/acheruva/enable_uninstall_pkg_test
branch
from
August 18, 2026 22:40
9f2d8da to
1c15c24
Compare
Pre-commit check failed⛔ pre-commit failed Please run locally:
This repo uses |
1 task
arvindcheru
force-pushed
the
users/acheruva/enable_uninstall_pkg_test
branch
from
August 28, 2026 14:08
b7f492c to
bc0bb22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request adds an optional uninstall and verification step to the native Linux package installation test workflow. After installing and verifying ROCm packages, the workflow can now optionally uninstall the packages and assert a clean system teardown. This is controlled by a new
run_uninstallinput/flag, and includes robust test coverage for the new logic.Part of #7252
ISSUE ID : #7252
Dependent Change: ROCm/rockrel#99
Technical Details
Uninstall and Verification Feature:
run_uninstallinput to the GitHub Actions workflow (.github/workflows/test_native_linux_packages_install.yml) to control whether uninstall and teardown verification are performed after install and verification steps. [1] [2] [3]native_linux_package_install_test.py, including methods to uninstall ROCm packages, verify removal, and ensure no ROCm packages remain installed. Also added a CLI flag (--with-uninstall) and corresponding environment variable (RUN_UNINSTALL) to trigger this behavior. [1] [2] [3] [4] [5] [6] [7] [8] [9]Test Plan
python3.12 -m unittest discover -s build_tools/packaging/linux/tests -p 'native_linux_package_install_ut_test.py'RUN_UNINSTALL=1on ubuntu2404RUN_UNINSTALL=1on rhel8 or rhel10RUN_UNINSTALL=1on sles16run_uninstallstill passestest_type: installskips uninstall even when flag is setTest Result
RHEL8 - Test - Native Linux packages Install (rhel8) · ROCm/TheRock@2940d15
RHEL10 - Test - Native Linux packages Install (rhel10) · ROCm/TheRock@2940d15
UB24 - Test - Native Linux packages Install (ubuntu2404) · ROCm/TheRock@2940d15
Submission Checklist