Skip to content

test(packaging): add uninstall test steps to the native Linux package installation test workflow - #7184

Open
arvindcheru wants to merge 8 commits into
mainfrom
users/acheruva/enable_uninstall_pkg_test
Open

test(packaging): add uninstall test steps to the native Linux package installation test workflow#7184
arvindcheru wants to merge 8 commits into
mainfrom
users/acheruva/enable_uninstall_pkg_test

Conversation

@arvindcheru

@arvindcheru arvindcheru commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Motivation

This pull request adds an optional uninstall and verification step to the native Linux package installation test workflow. After installing and verifying ROCm packages, the workflow can now optionally uninstall the packages and assert a clean system teardown. This is controlled by a new run_uninstall input/flag, and includes robust test coverage for the new logic.

Part of #7252
ISSUE ID : #7252

Dependent Change: ROCm/rockrel#99

Technical Details

Uninstall and Verification Feature:

  • Added a run_uninstall input to the GitHub Actions workflow (.github/workflows/test_native_linux_packages_install.yml) to control whether uninstall and teardown verification are performed after install and verification steps. [1] [2] [3]
  • Implemented uninstall logic in native_linux_package_install_test.py, including methods to uninstall ROCm packages, verify removal, and ensure no ROCm packages remain installed. Also added a CLI flag (--with-uninstall) and corresponding environment variable (RUN_UNINSTALL) to trigger this behavior. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Test Plan

  • python3.12 -m unittest discover -s build_tools/packaging/linux/tests -p 'native_linux_package_install_ut_test.py'
  • Local/CI sanity + RUN_UNINSTALL=1 on ubuntu2404
  • Local/CI sanity + RUN_UNINSTALL=1 on rhel8 or rhel10
  • Local/CI sanity + RUN_UNINSTALL=1 on sles16
  • Confirm default install CI without run_uninstall still passes
  • Confirm test_type: install skips uninstall even when flag is set

Test Result

RHEL8 - Test - Native Linux packages Install (rhel8) · ROCm/TheRock@2940d15
RHEL10 - Test - Native Linux packages Install (rhel10) · ROCm/TheRock@2940d15
UB24 - Test - Native Linux packages Install (ubuntu2404) · ROCm/TheRock@2940d15

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled
🤖 therock-pr-bot ✅ Pass

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Aug 7, 2026
@therock-pr-bot

therock-pr-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@arvindcheru
arvindcheru requested a review from nunnikri August 7, 2026 16:53
@arvindcheru
arvindcheru force-pushed the users/acheruva/enable_uninstall_pkg_test branch from 3bca8dc to 49b356e Compare August 10, 2026 21:52
@therock-pr-bot therock-pr-bot Bot removed the Not ready to Review PR has unresolved policy failures — reviews blocked label Aug 10, 2026
@arvindcheru
arvindcheru force-pushed the users/acheruva/enable_uninstall_pkg_test branch from 49b356e to 9f2d8da Compare August 10, 2026 22:40
@arvindcheru
arvindcheru marked this pull request as ready for review August 10, 2026 22:44
@arvindcheru
arvindcheru force-pushed the users/acheruva/enable_uninstall_pkg_test branch from 9f2d8da to 1c15c24 Compare August 18, 2026 22:40
@arvindcheru
arvindcheru requested a review from raramakr as a code owner August 18, 2026 22:40
@therock-pr-bot

Copy link
Copy Markdown

Pre-commit check failed

pre-commit failed

Please run locally:

  • python -m pip install pre-commit
  • pre-commit install
  • pre-commit run --all-files --show-diff-on-failure

This repo uses .pre-commit-config.yaml.

@arvindcheru
arvindcheru force-pushed the users/acheruva/enable_uninstall_pkg_test branch from b7f492c to bc0bb22 Compare August 28, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

1 participant