Skip to content

fix tile syntax in divide#746

Open
tingqli wants to merge 4 commits into
ROCm:mainfrom
tingqli:fixtiler
Open

fix tile syntax in divide#746
tingqli wants to merge 4 commits into
ROCm:mainfrom
tingqli:fixtiler

Conversation

@tingqli

@tingqli tingqli commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Motivation

fix issue in #739, align all divide behaviour with cuteDSL doc & pycute reference

Technical Details

Test Plan

Test Result

Submission Checklist

Copilot AI review requested due to automatic review settings June 25, 2026 12:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes FlyDSL’s divide-family semantics to align with CuTe/CuteDSL, addressing Issue #739 where zipped_divide could crash (notably with None elements in the tiler and when tiler rank < layout rank).

Changes:

  • Update Python divide wrappers to accept “bymode” integer divisors and route divisors through a unified coercion helper.
  • Fix C++ layoutZippedDivide / intTupleZip2By handling of None tiler modes to avoid rank-2 terminal assertion failures and match expected (1,s):(0,d) behavior.
  • Add unit tests covering logical_divide, zipped_divide, tiled_divide, and flat_divide for int, 1D tilers, and tilers containing None.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/unit/test_layout_algebra.py Adds regression/behavior tests for divide variants across bymode/int and None tiler cases.
python/flydsl/expr/primitive.py Changes divisor coercion for divide APIs; introduces _make_tile_or_layout and updates make_tile singleton handling.
include/flydsl/Dialect/Fly/Utils/LayoutUtils.h Updates zipped-divide guide construction and passes distinct noneValue for shape vs stride.
include/flydsl/Dialect/Fly/Utils/IntTupleUtils.h Extends intTupleZip2By to handle None guides explicitly and prevents problematic singleton-guide unwrapping.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread python/flydsl/expr/primitive.py Outdated
tingqli and others added 2 commits June 25, 2026 21:06
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@coderfeli coderfeli requested a review from sjfeng1999 June 26, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants