fix tile syntax in divide#746
Open
tingqli wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes FlyDSL’s divide-family semantics to align with CuTe/CuteDSL, addressing Issue #739 where zipped_divide could crash (notably with None elements in the tiler and when tiler rank < layout rank).
Changes:
- Update Python divide wrappers to accept “bymode” integer divisors and route divisors through a unified coercion helper.
- Fix C++
layoutZippedDivide/intTupleZip2Byhandling ofNonetiler modes to avoid rank-2 terminal assertion failures and match expected(1,s):(0,d)behavior. - Add unit tests covering
logical_divide,zipped_divide,tiled_divide, andflat_divideforint, 1D tilers, and tilers containingNone.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/unit/test_layout_algebra.py | Adds regression/behavior tests for divide variants across bymode/int and None tiler cases. |
| python/flydsl/expr/primitive.py | Changes divisor coercion for divide APIs; introduces _make_tile_or_layout and updates make_tile singleton handling. |
| include/flydsl/Dialect/Fly/Utils/LayoutUtils.h | Updates zipped-divide guide construction and passes distinct noneValue for shape vs stride. |
| include/flydsl/Dialect/Fly/Utils/IntTupleUtils.h | Extends intTupleZip2By to handle None guides explicitly and prevents problematic singleton-guide unwrapping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fix issue in #739, align all divide behaviour with cuteDSL doc & pycute reference
Technical Details
Test Plan
Test Result
Submission Checklist