-
Notifications
You must be signed in to change notification settings - Fork 5
updated documentation #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 1 commit
2269e0b
770c466
8c1dc06
4771966
e557c5d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,18 @@ | ||
| # StudyBits | ||
|
|
||
| ##Table of contents | ||
| 1. [Introduction](#introduction) | ||
| 2. [Contributing](#contributing) | ||
| 2.1 [Repository Structure](#structure) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this needs different alignment to properly render as nested list? (see https://help.github.com/en/articles/basic-writing-and-formatting-syntax#nested-lists) |
||
| 2.2 [Development Setup](#dev) | ||
| 2.3 [How to send a PR](#pullrequests) | ||
| 3. [Running StudyBits](#running) | ||
| 3.1 [Running in Docker](#RunInDocker) | ||
| 4. [System Diagrams](#diagrams) | ||
| 5. [Links](#links) | ||
|
|
||
|
|
||
| ## Introduction <a name="introduction"></a> | ||
| StudyBits allows students to receive credentials from their universities, and issue zero-knowledge proofs to other universities. | ||
|
|
||
| StudyBits leverages the [Sovrin network](https://sovrin.org/) to store DIDs, Schemas and Credential Definitions. | ||
|
|
@@ -10,16 +23,78 @@ The agent is used through the [StudyBits Wallet](https://github.com/Quintor/Stud | |
|
|
||
| Contact us on [Gitter](https://gitter.im/StudyBits/Lobby) | ||
|
|
||
| ## Running in docker | ||
|
|
||
| Use `TEST_POOL_IP=127.0.0.1 docker-compose up --build --force-recreate pool university-agent-rug university-agent-gent` | ||
| ## Contributing <a name="contributing"></a> | ||
|
|
||
| ### Repository Structure <a name="structure"></a> | ||
|
|
||
| The StudyBits repo consists of the following parts: | ||
|
|
||
| ``` | ||
| + ci | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would probably also use a nested list here (optional). |
||
| + Contains docker files used by trevor for ci. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. trevor -> Travis |
||
| + docs | ||
| + Contains design and implementation documentation. | ||
| + university-agent | ||
| + Contains java source-code for the university agent. | ||
| ``` | ||
|
|
||
| ### Development Setup <a name="dev"></a> | ||
|
|
||
| In order to develop for StudyBits a couple of dependencies need to be installed: | ||
|
|
||
| 1. Install [libindy](https://github.com/hyperledger/indy-sdk/tree/master/libindy) | ||
| The current version of StudyButs requires Libindy v1.6.6 to be installed, note that later versions are not supperted currently. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. supperted -> supported |
||
|
|
||
| 2. Make sure [Project Lombok](https://projectlombok.org/) can work it's magic. In your IDE of choice, please enable precompiling. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's -> its |
||
|
|
||
| ### How to send a PR <a name="pullrequests"></a> | ||
|
|
||
| Before sending a PR make sure to be complient with the following: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. complient -> compliant |
||
|
|
||
| ## Running tests in docker | ||
| + Do not create many PRs for one feature. Consider implementing a complete feature before sending a PR. | ||
| + Consider sending a design doc folder for a new feature. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe replace this with "if design is needed, create an issue to discuss before starting to code"? |
||
| + Make sure that a new feature or fix is covered by tests (try following TDD). | ||
| + Make sure that documentation is updated according to your changes. | ||
| + Provide a full description of changes in the PR. | ||
| + Make sure that static code validation passed. | ||
| + You need to make sure that all the tests pass. | ||
| + A reviewer or maintainer will merge the PR. | ||
|
|
||
| ## Running StudyBits <a name="running"></a> | ||
|
|
||
| ### Running in docker <a name="RunInDocker"></a> | ||
|
|
||
| Use `TEST_POOL_IP=127.0.0.1 docker-compose up --build --force-recreate pool university-agent-rug university-agent-gent` | ||
|
|
||
| Running tests: `TEST_POOL_IP=127.0.0.1 docker-compose up --build --force-recreate --exit-code-from tests` | ||
|
|
||
| ## Running outside of docker | ||
| Please note the the enviroment variable TEST_POOL_IP must be supplied as the IP of the HyperLedger indy nodes you wish to use. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe "The TEST_POOL_IP variable must match the ip address used to reach the HyperLedger Indy nodes that are spun up with docker-compose. This relevant if you are trying to reach these nodes from software not running in the docker-compose setup" describes better what's going on? |
||
|
|
||
| ## System Diagrams <a name="diagrams"></a> | ||
|
|
||
|  | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is more suited for a separate page, perhaps a .md in the docs folder that we can link here. For all other pictures, I'd either remove them, or reference them in a markdown file, otherwise they're just invisible. |
||
|
|
||
| ## Links <a name="links"></a> | ||
|
|
||
| #### StudyBits Native | ||
| [Quindy](https://github.com/Quintor/quindy) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These need to be lists to render properly |
||
| [StudentWallet](https://github.com/Quintor/StudyBitsWallet) | ||
|
|
||
| #### HyperLedger Indy | ||
| [Indy SDK](https://github.com/hyperledger/indy-sdk) | ||
| [Indy Node](https://github.com/hyperledger/indy-node) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you feel these links are helpful? I get that they are parts of the eco-system, but the documentation tends to be kind of lacking. (Specifically: node/plenum/agents). |
||
| [Indy Agents](https://github.com/hyperledger/indy-agent) | ||
| [indy plenum](https://github.com/hyperledger/indy-plenum/tree/master/docs) | ||
| [indy crypto](https://github.com/hyperledger/indy-crypto/blob/master/README.md) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indy crypto is being phased out in favour of HyperLedger Ursa (which is basically a rename of indy-crypto) |
||
|
|
||
| [Indy documentation old](https://wiki-archive.hyperledger.org/projects/indy/documentation) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's not link the old docs. The new docs are actually not at all being maintained either, so maybe let's remove them as well. Or move the collection of non-essential links to a separate page. |
||
| [Indy documentation new](https://hyperledger-indy.readthedocs.io/en/latest/) | ||
|
|
||
| #### Glossary | ||
| [sovrin glossary](https://docs.google.com/document/d/1giOzpTFXypJ6bAUp_6g93kYOEiNa5eWI1KeIg6wb598/edit) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sovrin -> Sovrin |
||
|
|
||
| To run backend locally, install libindy matching the version that is installed in the Dockerfile, [following their instructions](https://github.com/hyperledger/indy-sdk#installing-the-sdk) | ||
| #### Communication | ||
| [Agent-to-Agent communication videoexplaination](https://drive.google.com/file/d/1PHAy8dMefZG9JNg87Zi33SfKkZvUvXvx/view) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Haven't watched this, does it match the way we use an agent, or is it very specific to how the Indy people think agents should be built? |
||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a space between ## and title to render properly