fix(contentproviderutils): reject ImageLabelLoaded with a real reason - #777
Open
Quenty wants to merge 1 commit into
Open
fix(contentproviderutils): reject ImageLabelLoaded with a real reason#777Quenty wants to merge 1 commit into
Quenty wants to merge 1 commit into
Conversation
PromiseLoaded() rejected with no value on both the default-timeout path and the image-label-changed path, so callers logging the rejection printed "nil" and had nothing to debug with. The one message that did exist was also on the wrong branch: it blamed the "default timeout time" only when an explicit timeout had been passed. Both paths now reject with a message naming what happened, and the timeout message includes the timeout that elapsed. CircleCover is the only caller in-tree and already routes the reason to a warn. Claude-Session: https://claude.ai/code/session_01W7ZXw5EYfJ7uJeKUFrDivM
Test Results
29 packages tested, 29 passed, 0 failed in 1m48s Deploy Results
1 package deployed, 1 passed, 0 failed in 3.2s · View logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageLabelLoaded:PromiseLoaded() rejected with no value when it timed out on the default timeout or when the image label changed, so anything logging the rejection reason just printed "nil". The one message that did exist was on the wrong branch, blaming the default timeout only when an explicit timeout had been passed.
Both rejection paths now carry a message describing what happened, and the timeout message includes how long elapsed. Behavior is otherwise unchanged.
https://claude.ai/code/session_01W7ZXw5EYfJ7uJeKUFrDivM