Skip to content

refactor tk_to_qiskit internals #479

Description

@CalMacCQ

We've made some improvements in the past to refactor some of the more involved code on the qiskit_to_tk direction (converting qiskit QuantumCircuit to a pytket Circuit. See #313

The tk_to_qiskit direction is now the more problematic and messy part of the code. I found it a bit of a pain to work with during the qiskit v2 upgrade. I think it would be worth looking for oppurtunities to simplify the tk_to_qiskit converter (particularly the apply_tk_command_to_qiskit function here) to reduce maintence overhead

EDIT: We could refactor the handling of OpType.Conditional as well as most of the boxes out as separate helper functions. This would shorten the apply_tk_command_to_qiskit function and make the code a bit easier to follow.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions