Repository navigation
Conversation
Contributor
|
| Project | guppylang |
| Branch | codex/fix-generic-borrowed-callbacks-2486 |
| Testbed | Linux |
Click to view all benchmark results
| Benchmark | hugr_bytes | Benchmark Result bytes x 1e3 (Result Δ%) | Upper Boundary bytes x 1e3 (Limit %) | hugr_nodes | Benchmark Result nodes (Result Δ%) | Upper Boundary nodes (Limit %) |
|---|---|---|---|---|---|---|
| tests/benchmarks/test_big_array.py::test_big_array_compile | 📈 view plot 🚷 view threshold | 59.84 x 1e3(0.00%)Baseline: 59.84 x 1e3 | 60.44 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 4,514.00(0.00%)Baseline: 4,514.00 | 4,559.14 (99.01%) |
| tests/benchmarks/test_ctrl_flow.py::test_many_ctrl_flow_compile | 📈 view plot 🚷 view threshold | 26.87 x 1e3(0.00%)Baseline: 26.87 x 1e3 | 27.14 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 1,182.00(0.00%)Baseline: 1,182.00 | 1,193.82 (99.01%) |
| tests/benchmarks/test_queue_push_pop.py::test_queue_push_benchmark_compile | 📈 view plot 🚷 view threshold | 6.70 x 1e3(0.00%)Baseline: 6.70 x 1e3 | 6.77 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 279.00(0.00%)Baseline: 279.00 | 281.79 (99.01%) |
| tests/benchmarks/test_queue_push_pop.py::test_queue_push_pop_benchmark_compile | 📈 view plot 🚷 view threshold | 9.22 x 1e3(0.00%)Baseline: 9.22 x 1e3 | 9.31 x 1e3 (99.01%) | 📈 view plot 🚷 view threshold | 371.00(0.00%)Baseline: 371.00 | 374.71 (99.01%) |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2511 +/- ##
==========================================
- Coverage 93.36% 93.35% -0.02%
==========================================
Files 167 167
Lines 16950 17146 +196
==========================================
+ Hits 15826 16007 +181
- Misses 1124 1139 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance1 warning
Comparing |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exploratory callback-adapter implementation produced by Codex, left as a draft for a compiler developer to assess and pick up. Preserves borrowed function signatures and inserts adapters where callback calling conventions differ, with separate copyability and droppability checks.
Clearing borrowing flags during specialization broke mutation/write-back in
mem_swapandOption.swap. Named and specialized callbacks, nested callbacks, and tracing pass locally with the adapter approach; dynamically captured function adaptation still depends on experimental closure support and is not established as emulator-ready.Local checks: 2,198 passed, 25 skipped, 13 expected failures; notebook and pytket circuit modules were excluded after process crashes. Ruff and mypy passed. This is an investigation handoff, not a production-ready fix.
Closes #2486