feat: Add ComparatorRzDecomposer pass to the decompose module - #401
Open
PabloAndresCQ wants to merge 7 commits into
Open
PabloAndresCQ wants to merge 7 commits into
PabloAndresCQ wants to merge 7 commits into
Conversation
This reverts commit 59cb4fa.
… using ComparatorRzDecomposer
hsemenenko
approved these changes
Sep 15, 2026
hsemenenko
left a comment
hsemenenko
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Pablo! Left two suggestions.
PabloAndresCQ
commented
Sep 15, 2026
PabloAndresCQ
left a comment
PabloAndresCQ
left a comment
Collaborator
Author
There was a problem hiding this comment.
Let's have a final chat tomorrow during the group meeting before merging this. Otherwise, I think it's ready to go.
Thanks for creating #402. Let's also discuss tomorrow how urgent that is.
hsemenenko
reviewed
Sep 15, 2026
|
|
||
|
|
||
| def comparator_based_rz_cascade( | ||
| epsilon: float, |
Collaborator
There was a problem hiding this comment.
We need to add a check to validate that 0 < epsilon < 1 to avoid errors.
PabloAndresCQ
added this pull request to stack #405
September 16, 2026 07:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #362