docs: Clarify how classical operations behave in dagger blocks - #242
Merged
nicolaassolini-qntm merged 6 commits intoSep 15, 2026
Merged
Conversation
nicolaassolini-qntm
requested review from
CalMacCQ
and
a balanced review from Copilot
and removed request for
CalMacCQ
September 14, 2026 12:48
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation is accurate and scoped, with only a minor grammatical correction suggested.
Pull request overview
Documents supported classical computation within dagger blocks.
Changes:
- Explains classical-operation ordering.
- Adds a checked rotation example and its inverted sequence.
File summaries
| File | Description |
|---|---|
sphinx/language_guide/modifiers/dagger.md |
Documents classical operations in dagger blocks. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The documentation incorrectly guarantees source-order execution despite Guppy allowing some listed operations to be reordered.
Get a fresh assessment by requesting another Copilot review.
Review details
Suppressed comments (1)
sphinx/language_guide/modifiers/dagger.md:32
angles definitionis grammatically incorrect and makes this list nonparallel. Use consistent verb phrases for the examples.
Some simple classical operations, such as array indexing, angle construction, or arithmetic operations, are allowed inside dagger blocks.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
CalMacCQ
requested changes
Sep 15, 2026
CalMacCQ
left a comment
CalMacCQ
left a comment
Collaborator
There was a problem hiding this comment.
Thanks. Just one suggested rewording.
CalMacCQ
reviewed
Sep 15, 2026
Co-authored-by: Callum Macpherson <93673602+CalMacCQ@users.noreply.github.com>
Co-authored-by: Callum Macpherson <93673602+CalMacCQ@users.noreply.github.com>
CalMacCQ
approved these changes
Sep 15, 2026
nicolaassolini-qntm
deleted the
na/194-explain-classic-computation-dagger
branch
September 15, 2026 13:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #194
Note: Quantinuum/guppylang#2078 is still open, but after Quantinuum/guppylang#2176 and Quantinuum/guppylang#2140 we can do some classical computation.