Skip to content

refactor: various, inc runChecking, Graph inside Context - #122

Merged
croyzor merged 5 commits into
mainfrom
acl/refactor/run_checking
May 29, 2026
Merged

croyzor merged 5 commits into
mainfrom
acl/refactor/run_checking

Conversation

@acl-cqc

@acl-cqc acl-cqc commented May 15, 2026

Copy link
Copy Markdown
Collaborator
  • rename run to runChecking
  • Tidies to handler (lookupCon), error -> InternalError in Load.hs
  • correct some comments and remove defunct

Comment thread brat/Brat/Load.hs
remaining <- "check_defs" -! foldM checkDecl' to_define vdecls
if M.null remaining then pure () else error $ "loadStmtsWithEnv: expected to define " ++ show (M.keys remaining)
if M.null remaining then pure ()
else err $ InternalError $ "loadStmtsWithEnv: expected to define " ++ show (M.keys remaining)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the only change to behaviour in the PR

@acl-cqc
acl-cqc marked this pull request as ready for review May 15, 2026 18:17
@acl-cqc
acl-cqc requested a review from croyzor May 15, 2026 18:17
@croyzor
croyzor merged commit b753823 into main May 29, 2026
1 check failed
@croyzor
croyzor deleted the acl/refactor/run_checking branch May 29, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants