Skip to content

PPVM-traits-2 Patch - #219

Open
JonhasA wants to merge 4 commits into
mainfrom
trait-2/ppvm-traits-2
Open

PPVM-traits-2 Patch#219
JonhasA wants to merge 4 commits into
mainfrom
trait-2/ppvm-traits-2

Conversation

@JonhasA

@JonhasA JonhasA commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

A patch to move the changes to ppvm-trait from roger's PR #204

Additionally, the following changes were made:

  1. Added arithmetic module for defining traits to numeric types
  2. added gates module for defining traits for Clifford/ channel / measure/ rotation ops
  3. container module now has additional files related to storage or engine configuration
  4. Moved PREFER_MOVED_RKEY outside of coefficient and into storage.rs in containers/. Engine will configure the key rather than having coefficient module be responsible for it.
  5. Added a LossState trait to be associated with word sites rather than having it in PauliBits.
  6. Isolated functionality related to fermionic factors into fermion_factor.rs
  7. Pauli type is used explicitly for rotation operations
  8. Moves container tests beside their implementations and adds regression coverage for batch hash invalidation and Pauli-channel factors.
  9. Moves pauli_error_factors into the optional PauliErrorFactors channel capability, preserving the generic default and numeric specializations.

…em for ppvm. Focused on moving files to more isolated modules to have better appreciation on module responsibility

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Thanks for opening your first pull request against PPVM!

A quick note on contribution terms: by submitting this PR you
agree that your contribution is licensed under the
Apache License 2.0
and that you accept the
PPVM Contributor License Agreement.
Please skim those before a maintainer reviews — opening this PR
counts as your acceptance.

A few things that will speed up review:

  • Read CONTRIBUTING.md
    for the workflow, build commands, and style notes.
  • Run prek run --all-files locally; CI runs the same checks.
  • Use Conventional Commits
    for commit messages.

We'll get to your PR as soon as we can. Thanks for contributing!

@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://QuEraComputing.github.io/ppvm/pr-preview/pr-219/

Built to branch gh-pages at 2026-09-10 14:50 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant