Repository navigation
feat: added integration for PPVM simulator backend - #838
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
☂️ Code Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
jasonhan3
marked this pull request as ready for review
July 30, 2026 20:24
Member
|
@jasonhan3 can you use the conventional commit convention when creating the title for the PR |
jasonhan3
changed the title
github-actions
Bot
added
the
category: feature
weinbe58
requested changes
Aug 6, 2026
weinbe58
left a comment
weinbe58
left a comment
Member
There was a problem hiding this comment.
Needs a little bit of work but overall looks good!
Closed
6 tasks
weinbe58
approved these changes
Aug 10, 2026
weinbe58
left a comment
weinbe58
left a comment
Member
There was a problem hiding this comment.
Approving this but we will h
Contributor
Backport results for 214858eFailed:
To resolve manually: git fetch origin <release-branch>
git checkout -b backport-pr838 origin/<release-branch>
git cherry-pick 214858e1abf4651e88d7ee00102e51185f82b812
# resolve conflicts, then push and open a PR |
weinbe58
added a commit
that referenced
this pull request
Aug 10, 2026
…#905) feat: added integration for PPVM simulator backend (#838) * feat: added integration for PPVM simulator * feat: updated lockfile based on updated ppvm * feat: made PPVM lazy import with error message * fix: addressed PR comments * fix: added equality check for None * fix: changed test based on behavior --------- Co-authored-by: Jason Han <98669315+jasonhan3@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes:
Is a draft for now because uv.lock had a lot of changes due to a bug where-- Resolved with recent PPVM PR Renamed kirin to kirin-toolchain in pyproject.toml ppvm#199pyproject.tomlin PPVM installskirininstead ofkirin-toolchain, causing a bunch of extra unnecessary dependencies to be installedPPVMSimulatorBackendas anotherAbstractSimulatorBackendPPVMSimulatorBackend'ssamplereturnsmeasurementswith 3 values: False (|0>), True (|1>), and None (atom loss)._normalize_matrixinGeminiPhysicalSimulatorandGeminiLogicalSimulatorto add postprocessing to convert theNonevalues toTrueto model how Gemini-MVP doesn't support loss-resolved readout.