Skip to content

Add core symbolic gradient support to Pyomo.DoE #3898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snarasi2 wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Add core symbolic gradient support to Pyomo.DoE #3898

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
50cbc4a
Add symbolic gradient support to Pyomo.DoE
Apr 1, 2026
85116d5
Add symbolic DoE regression tests
Apr 1, 2026
12e5e95
Allow writeable in typos config
Apr 1, 2026
b35253a
Port polynomial and reactor symbolic tests
Apr 1, 2026
431b28e
Document symbolic gradient methods in DoE
Apr 1, 2026
f55a294
Refactor ExperimentGradients setup
Apr 1, 2026
ca66ac6
Add polynomial DoE regression coverage
Apr 1, 2026
8d8b8bd
Add broader gradient consistency tests
Apr 2, 2026
5c373fb
Add factorial results dataframe tests
Apr 2, 2026
103a121
Add reactor regression and CI fixes
Apr 2, 2026
76f53c4
Add plotting guard coverage tests
Apr 2, 2026
f28d86d
Clarify cyipopt HSL skip reason
Apr 2, 2026
80552f2
Reuse polynomial example in DoE tests
Apr 9, 2026
d708d55
Drop unused data arg from polynomial example
Apr 9, 2026
f53fe17
Clarify symbolic sensitivity math comments
Apr 9, 2026
11d475e
Remove no-op polynomial finalization
Apr 9, 2026
e704f68
Simplify polynomial test imports
Apr 9, 2026
0d0a14f
Remove redundant polynomial FIM smoke test
Apr 10, 2026
401c03a
Strengthen polynomial DoE regression test
Apr 10, 2026
0dd08eb
Use symbolic path for dataframe tests
Apr 10, 2026
65571da
Align symbolic DoE test coverage
Apr 10, 2026
9eb4959
Guard DoE utils tests on ipopt
Apr 10, 2026
702dc89
Strengthen symbolic Jacobian tests
Apr 10, 2026
d652cea
Remove out-of-scope FIM metric test
Apr 10, 2026
b5ea7f1
Tighten Jacobian regression assertions
Apr 10, 2026
9a78180
Drop workflow changes from symbolic PR
Apr 10, 2026
c593f0b
Checkpoint reactor test conversions to RB/polynomial
Apr 11, 2026
36d5694
Checkpoint remaining reactor test cleanup
Apr 11, 2026
dae72f4
Replace remaining reactor DoE tests
Apr 11, 2026
0545dcf
Clarify GreyBox MA57 skip reason
Apr 11, 2026
270bf8c
Add symbolic DoE PR notes
Apr 11, 2026
33d0b98
Refactor Jacobian rule setup
Apr 11, 2026
4209df5
Tighten FD scenario validation
Apr 11, 2026
653e3be
Format DoE module with black
Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/test_branches.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,7 +950,9 @@ jobs:
fi

- name: Upload codecov reports
Copy link
Copy Markdown
Contributor

@sscini sscini Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not used to seeing these files get modified or included in PRs? (In .github/workflows folder). Please explain these changes if they are needed or remove if possible.

Copy link
Copy Markdown
Author

@snarasi2 snarasi2 Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment on the PR in response to this

if: github.repository_owner == 'Pyomo' || github.ref != 'refs/heads/main'
if: |
hashFiles('coverage.xml') != '' &&
(github.repository_owner == 'Pyomo' || github.ref != 'refs/heads/main')
uses: codecov/codecov-action@v5
with:
files: coverage.xml
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/test_pr_and_main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1003,7 +1003,9 @@ jobs:
fi

- name: Upload codecov reports
if: github.repository_owner == 'Pyomo' || github.ref != 'refs/heads/main'
if: |
hashFiles('coverage.xml') != '' &&
(github.repository_owner == 'Pyomo' || github.ref != 'refs/heads/main')
uses: codecov/codecov-action@v5
with:
files: coverage.xml
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/typos.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,4 +81,6 @@ Bimap = "Bimap"
cmo = "cmo"
# Substituters
Substituters = "Substituters"
# NumPy flags attribute and existing user-facing messages
writeable = "writeable"
# AS NEEDED: Add More Words Below
4 changes: 2 additions & 2 deletions pyomo/contrib/doe/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
# Solutions of Sandia, LLC, the U.S. Government retains certain rights in this
# software. This software is distributed under the 3-clause BSD License.
# ____________________________________________________________________________________
from .doe import DesignOfExperiments, ObjectiveLib, FiniteDifferenceStep
from .utils import rescale_FIM
from .doe import DesignOfExperiments, ObjectiveLib, FiniteDifferenceStep, GradientMethod
from .utils import rescale_FIM, ExperimentGradients
from .grey_box_utilities import FIMExternalGreyBox

# Deprecation errors for old Pyomo.DoE interface classes and structures
Expand Down
Loading