Add non-limited API counterpart of bytearrayobject.rs#5966
Open
Add non-limited API counterpart of bytearrayobject.rs#5966
Conversation
Refactor PyByteArray functions to use PyByteArrayObject directly and add conditional compilation for GIL handling.
davidhewitt
reviewed
Apr 12, 2026
| pub unsafe fn PyByteArray_GET_SIZE(op: *mut PyObject) -> Py_ssize_t { | ||
| let byte_array = op as *mut PyByteArrayObject; | ||
| // _Py_atomic_load_ssize_relaxed and _PyVarObject_CAST not implemented | ||
| return _Py_atomic_load_ssize_relaxed(&(_PyVarObject_CAST(byte_array)->ob_size)); |
Member
There was a problem hiding this comment.
I would be ok with defining these functions with pub(crate) visibility in their respective headers, if we want this.
Co-authored-by: David Hewitt <mail@davidhewitt.dev>
Fix syntax error in conditional compilation and clean up imports.
Member
|
@clin1234 please let me know if you plan to carry out #5966 (comment) before more review needed. |
Contributor
Author
I would be willing to omit the no-GIL version of |
davidhewitt
approved these changes
Apr 14, 2026
Member
davidhewitt
left a comment
There was a problem hiding this comment.
In which case let's merge for now. 👍
Updated conditional compilation to exclude GraalPy along with PyPy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.