Repository navigation
Fix: added version check to import of pyproximal _x0z0_init - #212
Conversation
|
@rohanbabbar04 we recently released pyproximal v0.13.0 and I just realized since we did a bit of re-organization around the optimization package that a private method we are importing in pylops-mpi was moved... do you mind reviewing/approving and preparing a new release (since a couple of new things went in after v0.7.0 alongside this small fix 😄 ) |
rohanbabbar04
left a comment
There was a problem hiding this comment.
Thanks, looks good
Feel free to merge it 🙂
@rohanbabbar04 can you make a release so this is fixed also on pip install pylops-mpi or you want me to go ahead and do it? |
Sure, I will make a release tomorrow 🙂 |
This PR fixes the import of
pyproximal.optimization.primal._x0z0_initwhich inv0.13.0moved topyproximal.optimization.cls_primal._x0z0_initusing a switch on version so we don't force pylops-mpi to depend on the latest release of pyproximal.Moreover since pyproximal
v0.13.0introduced class-based proximal solvers, a slightly larger tol (1e-5) is now required for the proximal gradient tests - until we also switch to class-based distributed proximal solvers here.Finally, an update was required in the CuPy/NCCL GA to fix this issue https://github.com/PyLops/pylops-mpi/actions/runs/37999447028/job/114053677302