Skip to content

Fix: added version check to import of pyproximal _x0z0_init - #212

Merged
mrava87 merged 7 commits into
PyLops:mainfrom
mrava87:fix-import_pyprox
Oct 13, 2026
Merged

mrava87 merged 7 commits into
PyLops:mainfrom
mrava87:fix-import_pyprox

Conversation

@mrava87

@mrava87 mrava87 commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

This PR fixes the import of pyproximal.optimization.primal._x0z0_init which in v0.13.0 moved to pyproximal.optimization.cls_primal._x0z0_init using a switch on version so we don't force pylops-mpi to depend on the latest release of pyproximal.

Moreover since pyproximalv0.13.0 introduced class-based proximal solvers, a slightly larger tol (1e-5) is now required for the proximal gradient tests - until we also switch to class-based distributed proximal solvers here.

Finally, an update was required in the CuPy/NCCL GA to fix this issue https://github.com/PyLops/pylops-mpi/actions/runs/37999447028/job/114053677302

@mrava87
mrava87 requested a review from rohanbabbar04 October 10, 2026 19:55
@mrava87

mrava87 commented Oct 10, 2026

Copy link
Copy Markdown
Contributor Author

@rohanbabbar04 we recently released pyproximal v0.13.0 and I just realized since we did a bit of re-organization around the optimization package that a private method we are importing in pylops-mpi was moved... do you mind reviewing/approving and preparing a new release (since a couple of new things went in after v0.7.0 alongside this small fix 😄 )

@rohanbabbar04 rohanbabbar04 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good
Feel free to merge it 🙂

@mrava87
mrava87 merged commit 0280b36 into PyLops:main Oct 13, 2026
56 checks passed
@mrava87
mrava87 deleted the fix-import_pyprox branch October 13, 2026 21:04
@mrava87

mrava87 commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, looks good
Feel free to merge it 🙂

@rohanbabbar04 can you make a release so this is fixed also on pip install pylops-mpi or you want me to go ahead and do it?

@rohanbabbar04

Copy link
Copy Markdown
Collaborator

Thanks, looks good
Feel free to merge it 🙂

@rohanbabbar04 can you make a release so this is fixed also on pip install pylops-mpi or you want me to go ahead and do it?

Sure, I will make a release tomorrow 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants