Skip to content

add Tamil Mirador translation#4275

Merged
marlo-longley merged 3 commits intoProjectMirador:mainfrom
Natkeeran:tamil_local
Apr 22, 2026
Merged

add Tamil Mirador translation#4275
marlo-longley merged 3 commits intoProjectMirador:mainfrom
Natkeeran:tamil_local

Conversation

@Natkeeran
Copy link
Copy Markdown
Contributor

Adds a Tamil Mirador translation following this guide: https://github.com/ProjectMirador/mirador/blob/main/src/locales/README.md

Translations were contributed by Ushanthy Gowthaman from UofT Scarborough Library.

jcoyne
jcoyne previously approved these changes Apr 16, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.9%. Comparing base (ab59ae0) to head (b9f5692).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4275     +/-   ##
=======================================
+ Coverage   92.9%   92.9%   +0.1%     
=======================================
  Files        335     335             
  Lines       5530    5538      +8     
  Branches    1956    1960      +4     
=======================================
+ Hits        5135    5143      +8     
  Misses       348     348             
  Partials      47      47             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marlo-longley
Copy link
Copy Markdown
Member

@Natkeeran -- thank you for contributing this!

Copy link
Copy Markdown
Member

@marlo-longley marlo-longley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved this too early.
In testing I realized, in order for this work to be available we need to register the translation.

You need to modify this file in 2 places
https://github.com/ProjectMirador/mirador/blob/ab59ae0d7ac974dfee26a791fcc7f310e8d28733/src/i18n.js

  1. after line 24, import your new file
    import ta from './locales/ta/translation.json';
  2. after line 52, register the resource, by adding ta

With that fix in place I get the translations!
Screenshot 2026-04-17 at 2 49 54 PM

@Natkeeran
Copy link
Copy Markdown
Contributor Author

Thank you @marlo-longley

I've register the translation as noted above.

Copy link
Copy Markdown
Member

@marlo-longley marlo-longley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Natkeeran!

@marlo-longley marlo-longley merged commit 5841875 into ProjectMirador:main Apr 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants