Skip to content

Replace react-image with our own ImageWithFallback#4267

Open
jcoyne wants to merge 1 commit intomainfrom
image-fallback
Open

Replace react-image with our own ImageWithFallback#4267
jcoyne wants to merge 1 commit intomainfrom
image-fallback

Conversation

@jcoyne
Copy link
Copy Markdown
Collaborator

@jcoyne jcoyne commented Apr 2, 2026

react-image is no longer maintained and it's easy enough to write our own error handler

Fixes #4266

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.9%. Comparing base (2fcc336) to head (9b20df6).

Files with missing lines Patch % Lines
src/components/ImageWithFallback.jsx 83.4% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4267     +/-   ##
=======================================
- Coverage   93.0%   92.9%   -0.0%     
=======================================
  Files        335     336      +1     
  Lines       5530    5537      +7     
  Branches    1956    1957      +1     
=======================================
+ Hits        5141    5142      +1     
- Misses       346     348      +2     
- Partials      43      47      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

react-image is no longer maintained and it's easy enough to write our own error handler
@jcoyne jcoyne marked this pull request as ready for review April 2, 2026 15:27
@marlo-longley
Copy link
Copy Markdown
Member

Looks good. My only question is about the prettier reformatting -- is this on purpose to match the settings that will go in #4263?

@jcoyne
Copy link
Copy Markdown
Collaborator Author

jcoyne commented Apr 2, 2026

@marlo-longley my editor has prettier installed. It uses the defaults unless the application has a prettier config, then it will use that. So if we can get #4263 merged, then it'll just be a reformat call to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement placeholder without react-image dependency

2 participants