Replace react-image with our own ImageWithFallback#4267
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4267 +/- ##
=======================================
- Coverage 93.0% 92.9% -0.0%
=======================================
Files 335 336 +1
Lines 5530 5537 +7
Branches 1956 1957 +1
=======================================
+ Hits 5141 5142 +1
- Misses 346 348 +2
- Partials 43 47 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
react-image is no longer maintained and it's easy enough to write our own error handler
Member
|
Looks good. My only question is about the prettier reformatting -- is this on purpose to match the settings that will go in #4263? |
Collaborator
Author
|
@marlo-longley my editor has prettier installed. It uses the defaults unless the application has a prettier config, then it will use that. So if we can get #4263 merged, then it'll just be a reformat call to resolve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
react-image is no longer maintained and it's easy enough to write our own error handler
Fixes #4266