Fix #422: Added --fold argument and 5-fold cross-validation logic#428
Open
aman0311x wants to merge 2 commits into
Open
Fix #422: Added --fold argument and 5-fold cross-validation logic#428aman0311x wants to merge 2 commits into
aman0311x wants to merge 2 commits into
Conversation
for more information, see https://pre-commit.ci
WalkthroughThe BTCV training command now accepts a fold index. The data loader partitions the full training datalist into five folds, uses the selected fold for validation, and builds the training dataset from the remaining folds. ChangesBTCV cross-validation
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@UNETR/BTCV/main.py`:
- Line 94: Update the --fold argument definition in the argument parser to
validate that values are within the documented inclusive range 0–4, causing
argparse to reject invalid input before execution reaches folds[args.fold] in
data_utils.py.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a1d77ad9-7e37-4ac6-8eb5-f98f9d273c63
📒 Files selected for processing (2)
UNETR/BTCV/main.pyUNETR/BTCV/utils/data_utils.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issue #422. The repository mentioned using 5-fold cross-validation for the UNET/UNETR model on the BTCV dataset, but the
--foldargument was missing inmain.pyand the cross-validation data splitting logic was unimplemented.Changes Made
--foldargument to the argument parser inmain.py.partition_datasetinutils/data_utils.pybased on the requested fold index.Fixes #422
Summary by CodeRabbit
New Features
Bug Fixes