Skip to content

Show edit window and buttons below changes when using PageForms for chameleon version 4.4.x#436

Open
WouterRademaker wants to merge 3 commits into
ProfessionalWiki:4.xfrom
WouterRademaker:pagefrms44
Open

Show edit window and buttons below changes when using PageForms for chameleon version 4.4.x#436
WouterRademaker wants to merge 3 commits into
ProfessionalWiki:4.xfrom
WouterRademaker:pagefrms44

Conversation

@WouterRademaker

Copy link
Copy Markdown
Contributor

Should solve #319.
@ckapop found the issue that was causing this error and a solution. The changes were made suitable for and tested on Chameleon 4.4.1 by @WouterRademaker.

Same changes as #406

@WouterRademaker WouterRademaker changed the title Show edit window and buttons below changes when using PageForms for chameleon version 4.x Show edit window and buttons below changes when using PageForms for chameleon version 4.4.x Aug 5, 2024
@malberts

malberts commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

@WouterRademaker the failing tests suggest the new getHtml() is not getting mocked correctly. So this is a problem with this PR, not due to unrelated CI failures.

@WouterRademaker

WouterRademaker commented Oct 19, 2024

Copy link
Copy Markdown
Contributor Author

@malberts, but does this PR provide inspiration on how to solve this issue?

@WouterRademaker

Copy link
Copy Markdown
Contributor Author

@malberts, how do we get the new getHtml() mocked correctly? (If that is the right term)

@malberts

malberts commented Feb 2, 2025

Copy link
Copy Markdown
Contributor

@WouterRademaker I had a quick look at the code and this does not seem like the right approach.

The Component base class is supposed to get a ChameleonTemplate injected via constructor, and also has a getSkinTemplate() method for accessing it. However, in this PR there are no changes to how it is accessed, or even any other logic changes. It only replaces the existing instance of that ChameleonTemplate. If that fixes the problem, then it suggests there is something wrong with how that initial instance is created. The solution would require fixing that, not passing around a new instance and then replacing the existing instance after the component was already created.

@WouterRademaker

WouterRademaker commented Apr 25, 2025

Copy link
Copy Markdown
Contributor Author

@malberts, What would be the the right approach? How can we start with fixing it? #319 : "It seems the template created by the Page Form previews isn't making it's way down to the Chameleon components. "

@ckapop

ckapop commented Aug 4, 2025

Copy link
Copy Markdown

@WouterRademaker So, where do we stand with this? Have you looked into if the initial instance of ChameleonTemplate is the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants