Skip to content

Ensure PHP 8.1 compatibility#801

Draft
HamishSlater wants to merge 1 commit into
ProfessionalWiki:masterfrom
hallowelt:master
Draft

Ensure PHP 8.1 compatibility#801
HamishSlater wants to merge 1 commit into
ProfessionalWiki:masterfrom
hallowelt:master

Conversation

@HamishSlater

@HamishSlater HamishSlater commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator

Remove readonly modifier
Remove class constants with native types

ERM20742

@malberts

malberts commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

If we do this we should also lower the version in composer.json and CI.

I'm aware that MW 1.43 was released with PHP 8.1 support, but that PHP version is EOL by now. In which environment are you running where a newer version is unavailable?

@HamishSlater
HamishSlater force-pushed the master branch 2 times, most recently from fb52173 to 9fc7ca1 Compare April 30, 2026 13:56
@HamishSlater HamishSlater changed the title Remove readonly modifier to maintain PHP 8.1 compatibility Ensure PHP 8.1 compatibility Apr 30, 2026
Remove readonly modifier
Remove class constants with native types

ERM20742
@HamishSlater
HamishSlater marked this pull request as draft May 4, 2026 07:41
@JeroenDeDauw

Copy link
Copy Markdown
Member

@HamishSlater can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants